perf: Add --objdump option to perf top
PATCH 1/1 perf: Add --objdump option to perf top
perf: Add objdump option to 'perf top'
Like with 'perf annotate' add the --objdump option to perf top so users can specify an alternate path to the /usr/bin/objdump binary.
Reported-by David A. Gilbert <[email protected]>
Signed-off-by Sukadev Bhattiprolu <[email protected]>
--- tools/perf/builtin-top.c | 9 +++++++++ 1 files changed, 9 insertions(+), 0 deletions(-)
tools/perf/builtin-top.c +9 -0
@@ -40,6 +40,7 @@#include "util/xyarray.h" #include "util/sort.h" #include "util/intlist.h" +#include "arch/common.h" #include "util/debug.h"
@@ -942,6 +943,12 @@ static int __cmd_top(struct perf_top *top)if (top->session ==NULL )return -ENOMEM ; +if (!objdump_path) { + ret =perf_session_env__lookup_objdump (&top->session->header.env); +if (ret) + goto out_delete; + } + ret =perf_top__setup_sample_type (top);if (ret) goto out_delete;
@@ -1107,6 +1114,8 @@ int cmd_top(int argc, const char **argv, const char *prefix __maybe_unused) "Interleave source code with assembly code (default)"),OPT_BOOLEAN (0 ,"asm-raw" , &symbol_conf.annotate_asm_raw,"Display raw encoding of assembly instructions (default)" ), +OPT_STRING (0 ,"objdump" , &objdump_path,"path" , +"objdump binary to use for disassembly and annotations" ),OPT_STRING ('M' ,"disassembler-style" , &disassembler_style,"disassembler style" ,"Specify disassembler style (e.g. -M intel for intel syntax)" ), OPT_STRING('u', "uid", &target->uid_str, "user", "user to profile"),
Signature · 1 line
1.7.1
tip-bot for Sukadev Bhattiprolu
merge bot[tip:perf/core] perf top: Add --objdump option
perf top: Add --objdump option
Commit-ID: 0d3942dbcf7f7e8955ba89deed4749b0ad64d721 Gitweb: http://git.kernel.org/tip/0d3942dbcf7f7e8955ba89deed4749b0ad64d721 Author: Sukadev Bhattiprolu <[email protected]> AuthorDate: Tue, 14 May 2013 22:56:51 -0700 Committer: Arnaldo Carvalho de Melo <[email protected]> CommitDate: Fri, 12 Jul 2013 13:45:46 -0300
perf top: Add --objdump option
perf: Add objdump option to 'perf top'
Like with 'perf annotate' add the --objdump option to perf top so users can specify an alternate path to the /usr/bin/objdump binary.
Reported-by David A. Gilbert <[email protected]>
Signed-off-by Sukadev Bhattiprolu <[email protected]>
Cc Jiri Olsa <[email protected]>
Cc Maynard Johnson <[email protected]>
Signed-off-by Arnaldo Carvalho de Melo <[email protected]>
--- tools/perf/builtin-top.c | 9 +++++++++ 1 file changed, 9 insertions(+)
tools/perf/builtin-top.c +9 -0
@@ -40,6 +40,7 @@#include "util/xyarray.h" #include "util/sort.h" #include "util/intlist.h" +#include "arch/common.h" #include "util/debug.h"
@@ -939,6 +940,12 @@ static int __cmd_top(struct perf_top *top)if (top->session ==NULL )return -ENOMEM ; +if (!objdump_path) { + ret =perf_session_env__lookup_objdump (&top->session->header.env); +if (ret) + goto out_delete; + } + ret =perf_top__setup_sample_type (top);if (ret) goto out_delete;
@@ -1114,6 +1121,8 @@ int cmd_top(int argc, const char **argv, const char *prefix __maybe_unused) "Interleave source code with assembly code (default)"),OPT_BOOLEAN (0 ,"asm-raw" , &symbol_conf.annotate_asm_raw,"Display raw encoding of assembly instructions (default)" ), +OPT_STRING (0 ,"objdump" , &objdump_path,"path" , +"objdump binary to use for disassembly and annotations" ),OPT_STRING ('M' ,"disassembler-style" , &disassembler_style,"disassembler style" ,"Specify disassembler style (e.g. -M intel for intel syntax)" ), OPT_STRING('u', "uid", &target->uid_str, "user", "user to profile"),