Skip to contentSkip to conversation

x86: ptrace.c only needs export.h and not the full module.h

PATCH In review Paul Gortmaker 1 participant 2 messages Feb 14, 2013

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 x86: ptrace.c only needs export.h and not the full module.h

Commit cb57a2b4cff7edf2a4e32c0163200e9434807e0a ("x86-32: Export kernel_stack_pointer() for modules") added an include of the module.h header in conjunction with adding an EXPORT_SYMBOL_GPL of kernel_stack_pointer.

But module.h should be avoided for simple exports, since it in turn includes the world. Swap the module.h for export.h instead.

Cc H. Peter Anvin <[email protected]>
Cc Jiri Kosina <[email protected]>

---

[I didn't see this in tip/auto-latest so vectoring it via trivial]

 arch/x86/kernel/ptrace.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/x86/kernel/ptrace.c +1 -1
index b629bbe..29a8120 100644
@@ -22,7 +22,7 @@
 #include <linux/perf_event.h>
 #include <linux/hw_breakpoint.h>
 #include <linux/rcupdate.h>
-#include <linux/module.h>
+#include <linux/export.h>
 #include <linux/context_tracking.h>
 
 #include <asm/uaccess.h>
Signature · 1 line
1.8.1.2
#1 lore raw
Commit-ID:  19348e749e9515c429f5d561d2f2c724862a4bee
Gitweb:     http://git.kernel.org/tip/19348e749e9515c429f5d561d2f2c724862a4bee
Author:     Paul Gortmaker <[email protected]>
AuthorDate: Thu, 14 Feb 2013 15:14:02 -0500
Committer:  H. Peter Anvin <[email protected]>
CommitDate: Thu, 14 Feb 2013 12:56:12 -0800

x86: ptrace.c only needs export.h and not the full module.h

Commit cb57a2b4cff7edf2a4e32c0163200e9434807e0a ("x86-32: Export kernel_stack_pointer() for modules") added an include of the module.h header in conjunction with adding an EXPORT_SYMBOL_GPL of kernel_stack_pointer.

But module.h should be avoided for simple exports, since it in turn includes the world. Swap the module.h for export.h instead.

---
 arch/x86/kernel/ptrace.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/x86/kernel/ptrace.c +1 -1
index b629bbe..29a8120 100644
@@ -22,7 +22,7 @@
 #include <linux/perf_event.h>
 #include <linux/hw_breakpoint.h>
 #include <linux/rcupdate.h>
-#include <linux/module.h>
+#include <linux/export.h>
 #include <linux/context_tracking.h>
 
 #include <asm/uaccess.h>