hung_task: Display every hung task warning
Subsystems (3)
v4 cover hung_task: Display every hung task warning
From: Aaron Tomlin <[email protected]>
When khungtaskd detects hung tasks, it prints out backtraces from a number of those tasks. Limiting the number of backtraces being printed out can result in the user not seeing the information necessary to debug the issue. The hung_task_warnings sysctl controls this feature.
This patch makes it possible for hung_task_warnings to accept a special value to print an unlimited number of backtraces when khungtaskd detects hung tasks.
The special value is -1. To use this value it is necessary to change types from ulong to int.
Rebased against v3.13-rc8.
Changes since v3:
- Simplify the commit message (Rik van Riel and David Rientjes)
- Document hung_task_* sysctl parameters (David Rientjes)
Aaron Tomlin (2):
sysctl: Make neg_one a standard constraint
hung_task: Display every hung task warning
Documentation/sysctl/kernel.txt | 42 +++++++++++++++++++++++++++++++++++++++++ include/linux/sched/sysctl.h | 2 +- kernel/hung_task.c | 6 ++++-- kernel/sysctl.c | 6 ++++-- 4 files changed, 51 insertions(+), 5 deletions(-)
Signature · 1 line
1.8.4.2
RFC PATCH v4 1/2 sysctl: Make neg_one a standard constraint
From: Aaron Tomlin <[email protected]>
Add neg_one to the list of standard constraints.
--- kernel/sysctl.c | 1 + 1 file changed, 1 insertion(+)
kernel/sysctl.c +1 -0
@@ -122,6 +122,7 @@ extern int blk_iopoll_enabled;static int sixty =60 ;#endif +static int neg_one =-1 ;static int zero;static int __maybe_unused one =1 ;static int __maybe_unused two =2 ;
Signature · 1 line
1.8.4.2
Re: [RFC PATCH v4 1/2] sysctl: Make neg_one a standard constraint
Quoted 6 lines · On Mon, 20 Jan 2014, [email protected] wrote:
From: Aaron Tomlin <[email protected]>
Add
neg_oneto the list of standard constraints.Signed-off-by Aaron Tomlin <[email protected]>Acked-by Rik van Riel <[email protected]>
tip-bot for Aaron Tomlin
merge bot[tip:core/urgent] sysctl: Add neg_one as a standard constraint
In reply to [email protected]sysctl: Add neg_one as a standard constraint
Commit-ID: 2397efb1bb17595b35f31abb40d95074ebc04f1b Gitweb: http://git.kernel.org/tip/2397efb1bb17595b35f31abb40d95074ebc04f1b Author: Aaron Tomlin <[email protected]> AuthorDate: Mon, 20 Jan 2014 17:34:12 +0000 Committer: Ingo Molnar <[email protected]> CommitDate: Sat, 25 Jan 2014 08:59:53 +0100
sysctl: Add neg_one as a standard constraint
Add neg_one to the list of standard constraints - will be used by the next patch.
--- kernel/sysctl.c | 1 + 1 file changed, 1 insertion(+)
kernel/sysctl.c +1 -0
@@ -122,6 +122,7 @@ extern int blk_iopoll_enabled;static int sixty =60 ;#endif +static int neg_one =-1 ;static int zero;static int __maybe_unused one =1 ;static int __maybe_unused two =2 ;
RFC PATCH v4 2/2 hung_task: Display every hung task warning
In reply to [email protected]From: Aaron Tomlin <[email protected]>
When khungtaskd detects hung tasks, it prints out backtraces from a number of those tasks. Limiting the number of backtraces being printed out can result in the user not seeing the information necessary to debug the issue. The hung_task_warnings sysctl controls this feature.
This patch makes it possible for hung_task_warnings to accept a special value to print an unlimited number of backtraces when khungtaskd detects hung tasks.
The special value is -1. To use this value it is necessary to change types from ulong to int.
--- Documentation/sysctl/kernel.txt | 42 +++++++++++++++++++++++++++++++++++++++++ include/linux/sched/sysctl.h | 2 +- kernel/hung_task.c | 6 ++++-- kernel/sysctl.c | 5 +++-- 4 files changed, 50 insertions(+), 5 deletions(-)
Documentation/sysctl/kernel.txt +42 -0
@@ -33,6 +33,10 @@ show up in /proc/sys/kernel: - domainname - hostname - hotplug +- hung_task_panic +- hung_task_check_count +- hung_task_timeout_secs +- hung_task_warnings - kptr_restrict - kstack_depth_to_print [ X86 only ] - l2cr [ PPC only ]
@@ -287,6 +291,44 @@ Default value is "/sbin/hotplug". ============================================================== +hung_task_panic: + +Controls the kernel's behavior when a hung task is detected. +This file shows up if CONFIG_DETECT_HUNG_TASK is enabled. + +0: continue operation. This is the default behavior. + +1: panic immediately. + +============================================================== + +hung_task_check_count: + +The upper bound on the number of tasks that are checked. +This file shows up if CONFIG_DETECT_HUNG_TASK is enabled. + +============================================================== + +hung_task_timeout_secs: + +Check interval. When a task in D state did not get scheduled +for more than this value report a warning. +This file shows up if CONFIG_DETECT_HUNG_TASK is enabled. + +0: means infinite timeout - no checking done. + +============================================================== + +hung_task_warning: + +The maximum number of warnings to report. During a check interval +When this value is reached, no more the warnings will be reported. +This file shows up if CONFIG_DETECT_HUNG_TASK is enabled. + +-1: report an infinite number of warnings. + +============================================================== + kptr_restrict: This toggle indicates whether restrictions are placed on
include/linux/sched/sysctl.h +1 -1
@@ -5,7 +5,7 @@extern int sysctl_hung_task_check_count;extern unsigned int sysctl_hung_task_panic;extern unsigned long sysctl_hung_task_timeout_secs; -extern unsigned long sysctl_hung_task_warnings; +extern int sysctl_hung_task_warnings;extern int proc_dohung_task_timeout_secs (struct ctl_table *table,int write,void __user *buffer,size_t *lenp,loff_t *ppos);
kernel/hung_task.c +4 -2
@@ -37,7 +37,7 @@ int __read_mostly sysctl_hung_task_check_count = PID_MAX_LIMIT;*/ unsigned long __read_mostly sysctl_hung_task_timeout_secs =CONFIG_DEFAULT_HUNG_TASK_TIMEOUT ; -unsigned long __read_mostly sysctl_hung_task_warnings =10 ; +int __read_mostly sysctl_hung_task_warnings =10 ;static int __read_mostly did_panic;
@@ -98,7 +98,9 @@ static void check_hung_task(struct task_struct *t, unsigned long timeout)if (!sysctl_hung_task_warnings)return ; - sysctl_hung_task_warnings--; + +if (sysctl_hung_task_warnings >0 ) + sysctl_hung_task_warnings--;/* * Ok, the task did not get scheduled for more than 2 minutes,
kernel/sysctl.c +3 -2
@@ -985,9 +985,10 @@ static struct ctl_table kern_table[] = { { .procname = "hung_task_warnings", .data = &sysctl_hung_task_warnings, - .maxlen = sizeof(unsigned long), + .maxlen = sizeof(int), .mode = 0644, - .proc_handler = proc_doulongvec_minmax, + .proc_handler = proc_dointvec_minmax, + .extra1 = &neg_one, }, #endif #ifdef CONFIG_COMPAT
Signature · 1 line
1.8.4.2
Quoted 14 lines · On Mon, 20 Jan 2014, [email protected] wrote:
From: Aaron Tomlin <[email protected]>
When khungtaskd detects hung tasks, it prints out backtraces from a number of those tasks. Limiting the number of backtraces being printed out can result in the user not seeing the information necessary to debug the issue. The
hung_task_warningssysctl controls this feature.This patch makes it possible for
hung_task_warningsto accept a special value to print an unlimited number of backtraces when khungtaskd detects hung tasks.
Quoted 5 lines
The special value is -1. To use this value it is necessary to change types from ulong to int.
Signed-off-by Aaron Tomlin <[email protected]>Reviewed-by Rik van Riel <[email protected]>
Nice documentation updates!
tip-bot for Aaron Tomlin
merge bothung_task: Display every hung task warning
Commit-ID: 270750dbc18a71b23d660df110e433ff9616a2d4 Gitweb: http://git.kernel.org/tip/270750dbc18a71b23d660df110e433ff9616a2d4 Author: Aaron Tomlin <[email protected]> AuthorDate: Mon, 20 Jan 2014 17:34:13 +0000 Committer: Ingo Molnar <[email protected]> CommitDate: Sat, 25 Jan 2014 12:13:33 +0100
hung_task: Display every hung task warning
When khungtaskd detects hung tasks, it prints out backtraces from a number of those tasks.
Limiting the number of backtraces being printed out can result in the user not seeing the information necessary to debug the issue. The hung_task_warnings sysctl controls this feature.
This patch makes it possible for hung_task_warnings to accept a special value to print an unlimited number of backtraces when khungtaskd detects hung tasks.
The special value is -1. To use this value it is necessary to change types from ulong to int.
--- Documentation/sysctl/kernel.txt | 42 +++++++++++++++++++++++++++++++++++++++++ include/linux/sched/sysctl.h | 2 +- kernel/hung_task.c | 6 ++++-- kernel/sysctl.c | 8 +++++--- 4 files changed, 52 insertions(+), 6 deletions(-)
Documentation/sysctl/kernel.txt +42 -0
@@ -33,6 +33,10 @@ show up in /proc/sys/kernel: - domainname - hostname - hotplug +- hung_task_panic +- hung_task_check_count +- hung_task_timeout_secs +- hung_task_warnings - kptr_restrict - kstack_depth_to_print [ X86 only ] - l2cr [ PPC only ]
@@ -287,6 +291,44 @@ Default value is "/sbin/hotplug". ============================================================== +hung_task_panic: + +Controls the kernel's behavior when a hung task is detected. +This file shows up if CONFIG_DETECT_HUNG_TASK is enabled. + +0: continue operation. This is the default behavior. + +1: panic immediately. + +============================================================== + +hung_task_check_count: + +The upper bound on the number of tasks that are checked. +This file shows up if CONFIG_DETECT_HUNG_TASK is enabled. + +============================================================== + +hung_task_timeout_secs: + +Check interval. When a task in D state did not get scheduled +for more than this value report a warning. +This file shows up if CONFIG_DETECT_HUNG_TASK is enabled. + +0: means infinite timeout - no checking done. + +============================================================== + +hung_task_warning: + +The maximum number of warnings to report. During a check interval +When this value is reached, no more the warnings will be reported. +This file shows up if CONFIG_DETECT_HUNG_TASK is enabled. + +-1: report an infinite number of warnings. + +============================================================== + kptr_restrict: This toggle indicates whether restrictions are placed on
include/linux/sched/sysctl.h +1 -1
@@ -5,7 +5,7 @@extern int sysctl_hung_task_check_count;extern unsigned int sysctl_hung_task_panic;extern unsigned long sysctl_hung_task_timeout_secs; -extern unsigned long sysctl_hung_task_warnings; +extern int sysctl_hung_task_warnings;extern int proc_dohung_task_timeout_secs (struct ctl_table *table,int write,void __user *buffer,size_t *lenp,loff_t *ppos);
kernel/hung_task.c +4 -2
@@ -37,7 +37,7 @@ int __read_mostly sysctl_hung_task_check_count = PID_MAX_LIMIT;*/ unsigned long __read_mostly sysctl_hung_task_timeout_secs =CONFIG_DEFAULT_HUNG_TASK_TIMEOUT ; -unsigned long __read_mostly sysctl_hung_task_warnings =10 ; +int __read_mostly sysctl_hung_task_warnings =10 ;static int __read_mostly did_panic;
@@ -98,7 +98,9 @@ static void check_hung_task(struct task_struct *t, unsigned long timeout)if (!sysctl_hung_task_warnings)return ; - sysctl_hung_task_warnings--; + +if (sysctl_hung_task_warnings >0 ) + sysctl_hung_task_warnings--;/* * Ok, the task did not get scheduled for more than 2 minutes,
kernel/sysctl.c +5 -3
@@ -122,7 +122,8 @@ extern int blk_iopoll_enabled;static int sixty =60 ;#endif -static int neg_one =-1 ; +static int __maybe_unused neg_one =-1 ; +static int zero;static int __maybe_unused one =1 ;static int __maybe_unused two =2 ;
@@ -978,9 +979,10 @@ static struct ctl_table kern_table[] = { { .procname = "hung_task_warnings", .data = &sysctl_hung_task_warnings, - .maxlen = sizeof(unsigned long), + .maxlen = sizeof(int), .mode = 0644, - .proc_handler = proc_doulongvec_minmax, + .proc_handler = proc_dointvec_minmax, + .extra1 = &neg_one, }, #endif #ifdef CONFIG_COMPAT