Skip to contentSkip to conversation

perf, tools, stat: Quieten failed to read counter message

PATCH Applied Andi Kleen 4 participants 4 messages Sep 1, 2015 – Sep 8, 2015 perf events

lore
Share & tools
lore

Andi Kleen

author
#0 lore raw

PATCH 1/1 perf, tools, stat: Quieten failed to read counter message

From: Andi Kleen <[email protected]>

Since 3b3eb0445 running perf stat on a system without backend-stalled-cycles spits out ugly warnings by default. Since that is quite common, make the message a debug message only. We know
anyways that the counter wasn't read by the normal <unsupported> output.

---
 tools/perf/builtin-stat.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/perf/builtin-stat.c +1 -1
index d46dbb1..a96fb5c 100644
@@ -215,7 +215,7 @@ static void read_counters(bool close_counters)
 
 	evlist__for_each(evsel_list, counter) {
 		if (read_counter(counter))
-			pr_warning("failed to read counter %s\n", counter->name);
+			pr_debug("failed to read counter %s\n", counter->name);
 
 		if (perf_stat_process_counter(&stat_config, counter))
 			pr_warning("failed to process counter %s\n", counter->name);
Signature · 1 line
2.4.3
Acked-by on v1 1/1
#1 lore raw
Quoted 7 lines · Andi Kleen

From: Andi Kleen <[email protected]>

Since 3b3eb0445 running perf stat on a system without backend-stalled-cycles spits out ugly warnings by default. Since that is quite common, make the message a debug message only. We know
anyways that the counter wasn't read by the normal <unsupported> output.

thanks,
jirka

Quoted 22 lines
---
 tools/perf/builtin-stat.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/perf/builtin-stat.c +1 -1
index d46dbb1..a96fb5c 100644
@@ -215,7 +215,7 @@ static void read_counters(bool close_counters)
 
 	evlist__for_each(evsel_list, counter) {
 		if (read_counter(counter))
-			pr_warning("failed to read counter %s\n", counter->name);
+			pr_debug("failed to read counter %s\n", counter->name);
 
 		if (perf_stat_process_counter(&stat_config, counter))
 			pr_warning("failed to process counter %s\n", counter->name);
Signature · 1 line
2.4.3
maintainer Applied
#2 lore raw

Em Wed, Sep 02, 2015 at 08:07:20AM +0200, Jiri Olsa escreveu:

Quoted 10 lines · Andi Kleen
Quoted 7 lines

From: Andi Kleen <[email protected]>

Since 3b3eb0445 running perf stat on a system without backend-stalled-cycles spits out ugly warnings by default. Since that is quite common, make the message a debug message only. We know
anyways that the counter wasn't read by the normal <unsupported> output.

Thanks, applied.

- Arnaldo

#3 lore raw

[tip:perf/core] perf stat: Quieten failed to read counter message

In reply to Andi Kleen
perf stat: Quieten failed to read counter message
Commit-ID:  245bad8eb45fca36638da53fb0a361397a707001
Gitweb:     http://git.kernel.org/tip/245bad8eb45fca36638da53fb0a361397a707001
Author:     Andi Kleen <[email protected]>
AuthorDate: Tue, 1 Sep 2015 15:52:46 -0700
Committer:  Arnaldo Carvalho de Melo <[email protected]>
CommitDate: Wed, 2 Sep 2015 16:30:47 -0300

perf stat: Quieten failed to read counter message

Since 3b3eb0445 running perf stat on a system without backend-stalled-cycles spits out ugly warnings by default.

Since that is quite common, make the message a debug message only.

We know anyways that the counter wasn't read by the normal <unsupported> output.

---
 tools/perf/builtin-stat.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/perf/builtin-stat.c +1 -1
index d46dbb1..a96fb5c 100644
@@ -215,7 +215,7 @@ static void read_counters(bool close_counters)
 
 	evlist__for_each(evsel_list, counter) {
 		if (read_counter(counter))
-			pr_warning("failed to read counter %s\n", counter->name);
+			pr_debug("failed to read counter %s\n", counter->name);
 
 		if (perf_stat_process_counter(&stat_config, counter))
 			pr_warning("failed to process counter %s\n", counter->name);