Skip to contentSkip to conversation

perf symbols: symbol inconsistency message should be done only at verbose=1

tip:perf/core tip-bot for Arnaldo Carvalho de Melo 1 participant 1 message May 17, 2010 perf events

lore
Share & tools
lore
#0 lore raw
Commit-ID:  2f51903bc3139e25ec908f8944a0001c7b868e90
Gitweb:     http://git.kernel.org/tip/2f51903bc3139e25ec908f8944a0001c7b868e90
Author:     Arnaldo Carvalho de Melo <[email protected]>
AuthorDate: Mon, 17 May 2010 17:57:59 -0300
Committer:  Arnaldo Carvalho de Melo <[email protected]>
CommitDate: Mon, 17 May 2010 17:57:59 -0300

perf symbols: symbol inconsistency message should be done only at verbose=1

That happened for an old perf.data file that had no fake MMAP events for the kernel modules, but even then it should warn once for each module, not one time for every symbol in every module not found.

LKML-Reference: <new-submission>

---
 tools/perf/util/symbol.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
tools/perf/util/symbol.c +1 -1
index ecccc8d..a06131f 100644
@@ -525,7 +525,7 @@ static int dso__split_kallsyms(struct dso *self, struct map *map,
 				curr_map = map_groups__find_by_name(kmaps,
 							map->type, module);
 				if (curr_map == NULL) {
-					pr_err("%s/proc/{kallsyms,modules} "
+					pr_debug("%s/proc/{kallsyms,modules} "
 					         "inconsistency while looking "
 						 "for \"%s\" module!\n",
 						 machine->root_dir, module);