arch/x86/mm/srat: Print non-volatile flag in SRAT
PATCH v2 1/1 arch/x86/mm/srat: Print non-volatile flag in SRAT
With the addition of NVDIMM support, a question came up as to whether NVDIMM ranges should be in the SRAT with this bit set. I think the consensus was no because the ranges are in the NFIT with proximity domain information there.
ACPI is not clear on the meaning of this bit in the SRAT. If someone is setting it, we might want to ask them what they expect to happen with it.
Right now this bit is only printed if all the ACPI debug information is turned on.
--- arch/x86/mm/srat.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
arch/x86/mm/srat.c +3 -2
@@ -192,10 +192,11 @@ acpi_numa_memory_affinity_init(struct acpi_srat_mem_affinity *ma)node_set (node, numa_nodes_parsed); -pr_info ("SRAT: Node %u PXM %u [mem %#010Lx-%#010Lx]%s\n" , +pr_info ("SRAT: Node %u PXM %u [mem %#010Lx-%#010Lx]%s%s\n" , node, pxm, (unsigned long long ) start, (unsigned long long ) end -1 , - hotpluggable ?" hotplug" :"" ); + hotpluggable ?" hotplug" :"" , + ma->flags &ACPI_SRAT_MEM_NON_VOLATILE ?" non-volatile" :"" );/* Mark hotplug range in memblock. */ if (hotpluggable &&memblock_mark_hotplug (start, ma->length))
Signature · 1 line
1.8.3.1
tip-bot for Linda Knippers
merge bot[tip:x86/urgent] x86/mm/srat: Print non-volatile flag in SRAT
x86/mm/srat: Print non-volatile flag in SRAT
Commit-ID: 31e09b18c863718939e3e9c30eee55f9011d85ee Gitweb: http://git.kernel.org/tip/31e09b18c863718939e3e9c30eee55f9011d85ee Author: Linda Knippers <[email protected]> AuthorDate: Tue, 1 Sep 2015 15:41:55 -0400 Committer: Ingo Molnar <[email protected]> CommitDate: Wed, 2 Sep 2015 09:33:25 +0200
x86/mm/srat: Print non-volatile flag in SRAT
With the addition of NVDIMM support, a question came up as to whether NVDIMM ranges should be in the SRAT with this bit set. I think the consensus was no because the ranges are in the NFIT with proximity domain information there.
ACPI is not clear on the meaning of this bit in the SRAT. If someone is setting it, we might want to ask them what they expect to happen with it.
Right now this bit is only printed if all the ACPI debug information is turned on.
--- arch/x86/mm/srat.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
arch/x86/mm/srat.c +3 -2
@@ -192,10 +192,11 @@ acpi_numa_memory_affinity_init(struct acpi_srat_mem_affinity *ma)node_set (node, numa_nodes_parsed); -pr_info ("SRAT: Node %u PXM %u [mem %#010Lx-%#010Lx]%s\n" , +pr_info ("SRAT: Node %u PXM %u [mem %#010Lx-%#010Lx]%s%s\n" , node, pxm, (unsigned long long ) start, (unsigned long long ) end -1 , - hotpluggable ?" hotplug" :"" ); + hotpluggable ?" hotplug" :"" , + ma->flags &ACPI_SRAT_MEM_NON_VOLATILE ?" non-volatile" :"" );/* Mark hotplug range in memblock. */ if (hotpluggable &&memblock_mark_hotplug (start, ma->length))