Skip to contentSkip to conversation

debugobjects: fill_pool() returns void now

PATCH In review Dan Carpenter 1 participant 2 messages Apr 18, 2012

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 debugobjects: fill_pool() returns void now

There was a return missed in 1fda107d44 "debugobjects: Remove unused return value from fill_pool()". It makes gcc complain:

lib/debugobjects.c: In function ‘fill_pool’:
lib/debugobjects.c:98:4: warning: ‘return’ with a value, in
function returning void [enabled by default]

lib/debugobjects.c +1 -1
index 1b6c00a..d11808c 100644
@@ -95,7 +95,7 @@ static void fill_pool(void)
 
 		new = kmem_cache_zalloc(obj_cache, gfp);
 		if (!new)
-			return obj_pool_free;
+			return;
 
 		raw_spin_lock_irqsave(&pool_lock, flags);
 		hlist_add_head(&new->node, &obj_pool);
#1 lore raw

[tip:core/debugobjects] debugobjects: Fill_pool() returns void now

Commit-ID:  3340808cf04faad7b87d6c6e13800825e5552b51
Gitweb:     http://git.kernel.org/tip/3340808cf04faad7b87d6c6e13800825e5552b51
Author:     Dan Carpenter <[email protected]>
AuthorDate: Wed, 18 Apr 2012 14:28:10 +0300
Committer:  Thomas Gleixner <[email protected]>
CommitDate: Wed, 18 Apr 2012 13:38:48 +0200

debugobjects: Fill_pool() returns void now

There was a return missed in 1fda107d44 "debugobjects: Remove unused return value from fill_pool()". It makes gcc complain:

lib/debugobjects.c: In function ‘fill_pool’:
lib/debugobjects.c:98:4: warning: ‘return’ with a value, in
function returning void [enabled by default]

---
 lib/debugobjects.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
lib/debugobjects.c +1 -1
index 1b6c00a..d11808c 100644
@@ -95,7 +95,7 @@ static void fill_pool(void)
 
 		new = kmem_cache_zalloc(obj_cache, gfp);
 		if (!new)
-			return obj_pool_free;
+			return;
 
 		raw_spin_lock_irqsave(&pool_lock, flags);
 		hlist_add_head(&new->node, &obj_pool);