Skip to contentSkip to conversation

x86/AMD: Fix LLC topology for AMD Fam17h systems

PATCH New Aravind Gopalakrishnan 2 participants 3 messages Nov 3, 2015 – Nov 7, 2015 x86

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 x86/AMD: Fix LLC topology for AMD Fam17h systems

On AMD Fam17h systems, the last level cache is not resident in Northbridge. Therefore, we cannot assign cpu_llc_id to same value as Node ID (as we have been doing currently)

We should rather look at the ApicID bits of the core to provide us the last level cache ID info. Doing that here.

---
Changes in V2:
- Move LLC calculation logic to amd_detect_cmp() and change patch header as a result. (This in turn fixes the issue found by kbuild bot on the V1 patch)

 arch/x86/kernel/cpu/amd.c | 13 +++++++++++++
 1 file changed, 13 insertions(+)
arch/x86/kernel/cpu/amd.c +13 -0
index 4a70fc6..dab371e 100644
@@ -352,6 +352,8 @@ static void amd_detect_cmp(struct cpuinfo_x86 *c)
 #ifdef CONFIG_SMP
 	unsigned bits;
 	int cpu = smp_processor_id();
+	unsigned int apicid = c->apicid;
+	unsigned int socket_id, core_complex_id;
 
 	bits = c->x86_coreid_bits;
 	/* Low order bits define the core id (index of core in socket) */
@@ -361,6 +363,17 @@ static void amd_detect_cmp(struct cpuinfo_x86 *c)
 	/* use socket ID also for last level cache */
 	per_cpu(cpu_llc_id, cpu) = c->phys_proc_id;
 	amd_get_topology(c);
+
+	/*
+	 * Fix percpu cpu_llc_id here as LLC topology is different
+	 * for Fam17h systems.
+	 */
+	 if (c->x86 != 0x17 || !cpuid_edx(0x80000006))
+		return;
+
+	socket_id = (apicid >> bits) - 1;
+	core_complex_id = (apicid & ((1 << bits) - 1)) >> 3;
+	per_cpu(cpu_llc_id, cpu) = (socket_id << 3) | core_complex_id;
 #endif
 }
 
Signature · 1 line
2.6.1
#1 lore raw

[tip:x86/urgent] x86/AMD: Fix last level cache topology for AMD Fam17h systems

x86/AMD: Fix last level cache topology for AMD Fam17h systems
Commit-ID:  e5e84a26ef2909964d964224b805236293fb4c63
Gitweb:     http://git.kernel.org/tip/e5e84a26ef2909964d964224b805236293fb4c63
Author:     Aravind Gopalakrishnan <[email protected]>
AuthorDate: Wed, 4 Nov 2015 12:49:42 +0100
Committer:  Thomas Gleixner <[email protected]>
CommitDate: Wed, 4 Nov 2015 12:52:06 +0100

x86/AMD: Fix last level cache topology for AMD Fam17h systems

On AMD Fam17h systems, the last level cache is not resident in the northbridge. Therefore, we cannot assign cpu_llc_id to the same value as Node ID as we have been doing until now.

We should rather look at the ApicID bits of the core to provide us the last level cache ID info.

---
 arch/x86/kernel/cpu/amd.c | 13 +++++++++++++
 1 file changed, 13 insertions(+)
arch/x86/kernel/cpu/amd.c +13 -0
index 4a70fc6..a8816b3 100644
@@ -352,6 +352,7 @@ static void amd_detect_cmp(struct cpuinfo_x86 *c)
 #ifdef CONFIG_SMP
 	unsigned bits;
 	int cpu = smp_processor_id();
+	unsigned int socket_id, core_complex_id;
 
 	bits = c->x86_coreid_bits;
 	/* Low order bits define the core id (index of core in socket) */
@@ -361,6 +362,18 @@ static void amd_detect_cmp(struct cpuinfo_x86 *c)
 	/* use socket ID also for last level cache */
 	per_cpu(cpu_llc_id, cpu) = c->phys_proc_id;
 	amd_get_topology(c);
+
+	/*
+	 * Fix percpu cpu_llc_id here as LLC topology is different
+	 * for Fam17h systems.
+	 */
+	 if (c->x86 != 0x17 || !cpuid_edx(0x80000006))
+		return;
+
+	socket_id	= (c->apicid >> bits) - 1;
+	core_complex_id	= (c->apicid & ((1 << bits) - 1)) >> 3;
+
+	per_cpu(cpu_llc_id, cpu) = (socket_id << 3) | core_complex_id;
 #endif
 }
 
#2 lore raw

[tip:x86/urgent] x86/AMD: Fix last level cache topology for AMD Fam17h systems

In reply to Aravind Gopalakrishnan
x86/AMD: Fix last level cache topology for AMD Fam17h systems
Commit-ID:  3849e91f571dcb48cf2c8143480c59137d44d6bc
Gitweb:     http://git.kernel.org/tip/3849e91f571dcb48cf2c8143480c59137d44d6bc
Author:     Aravind Gopalakrishnan <[email protected]>
AuthorDate: Wed, 4 Nov 2015 12:49:42 +0100
Committer:  Thomas Gleixner <[email protected]>
CommitDate: Sat, 7 Nov 2015 10:37:51 +0100

x86/AMD: Fix last level cache topology for AMD Fam17h systems

On AMD Fam17h systems, the last level cache is not resident in the northbridge. Therefore, we cannot assign cpu_llc_id to the same value as Node ID as we have been doing until now.

We should rather look at the ApicID bits of the core to provide us the last level cache ID info.

---
 arch/x86/kernel/cpu/amd.c | 13 +++++++++++++
 1 file changed, 13 insertions(+)
arch/x86/kernel/cpu/amd.c +13 -0
index 4a70fc6..a8816b3 100644
@@ -352,6 +352,7 @@ static void amd_detect_cmp(struct cpuinfo_x86 *c)
 #ifdef CONFIG_SMP
 	unsigned bits;
 	int cpu = smp_processor_id();
+	unsigned int socket_id, core_complex_id;
 
 	bits = c->x86_coreid_bits;
 	/* Low order bits define the core id (index of core in socket) */
@@ -361,6 +362,18 @@ static void amd_detect_cmp(struct cpuinfo_x86 *c)
 	/* use socket ID also for last level cache */
 	per_cpu(cpu_llc_id, cpu) = c->phys_proc_id;
 	amd_get_topology(c);
+
+	/*
+	 * Fix percpu cpu_llc_id here as LLC topology is different
+	 * for Fam17h systems.
+	 */
+	 if (c->x86 != 0x17 || !cpuid_edx(0x80000006))
+		return;
+
+	socket_id	= (c->apicid >> bits) - 1;
+	core_complex_id	= (c->apicid & ((1 << bits) - 1)) >> 3;
+
+	per_cpu(cpu_llc_id, cpu) = (socket_id << 3) | core_complex_id;
 #endif
 }