Skip to contentSkip to conversation

x86/intel_rdt: Remove redundant assignment

PATCH New Jithu Joseph 2 participants 2 messages Oct 4, 2017 – Oct 5, 2017 x86

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 x86/intel_rdt: Remove redundant assignment

The assignment to the 'files' variable is immediately overwritten in the following line. Remove the older assignment, which was meant specifially for creating control groups files.

Fixes c7d9aac61311 ("x86/intel_rdt/cqm: Add mkdir support for RDT monitoring")
---
 arch/x86/kernel/cpu/intel_rdt_rdtgroup.c | 1 -
 1 file changed, 1 deletion(-)
arch/x86/kernel/cpu/intel_rdt_rdtgroup.c +0 -1
index a869d4a..dc22064 100644
@@ -1560,7 +1560,6 @@ static int mkdir_rdt_prepare(struct kernfs_node *parent_kn,
 	if (ret)
 		goto out_destroy;
 
-	files = RFTYPE_BASE | RFTYPE_CTRL;
 	files = RFTYPE_BASE | BIT(RF_CTRLSHIFT + rtype);
 	ret = rdtgroup_add_files(kn, files);
 	if (ret)
Signature · 1 line
1.9.1
#1 lore raw
x86/intel_rdt: Remove redundant assignment
Commit-ID:  3916a4135c696fa226a1abe6d6a0ff7f5edd9a7c
Gitweb:     https://git.kernel.org/tip/3916a4135c696fa226a1abe6d6a0ff7f5edd9a7c
Author:     Jithu Joseph <[email protected]>
AuthorDate: Wed, 4 Oct 2017 15:48:57 -0700
Committer:  Thomas Gleixner <[email protected]>
CommitDate: Thu, 5 Oct 2017 13:20:32 +0200

x86/intel_rdt: Remove redundant assignment

The assignment to the 'files' variable is immediately overwritten in the following line. Remove the older assignment, which was meant specifially for creating control groups files.

---
 arch/x86/kernel/cpu/intel_rdt_rdtgroup.c | 1 -
 1 file changed, 1 deletion(-)
arch/x86/kernel/cpu/intel_rdt_rdtgroup.c +0 -1
index abd220b..8a61b20 100644
@@ -1635,7 +1635,6 @@ static int mkdir_rdt_prepare(struct kernfs_node *parent_kn,
 		goto out_destroy;
 	}
 
-	files = RFTYPE_BASE | RFTYPE_CTRL;
 	files = RFTYPE_BASE | BIT(RF_CTRLSHIFT + rtype);
 	ret = rdtgroup_add_files(kn, files);
 	if (ret) {