Skip to contentSkip to conversation

x86/mm: remove stale comment about kmemcheck

PATCH New Jann Horn 2 participants 2 messages Feb 19, 2018 – Feb 20, 2018

Subsystems (2)
lore
Share & tools
lore

Jann Horn

author
#0 lore raw

PATCH 1/1 x86/mm: remove stale comment about kmemcheck

This comment referred to a conditional call to kmemcheck_hide() that was here until commit 4950276672fc ("kmemcheck: remove annotations"). Now that kmemcheck has been removed, it doesn't make sense anymore.

---
 arch/x86/mm/fault.c | 4 ----
 1 file changed, 4 deletions(-)
arch/x86/mm/fault.c +0 -4
index 800de815519c..c88573d90f3e 100644
@@ -1248,10 +1248,6 @@ __do_page_fault(struct pt_regs *regs, unsigned long error_code,
 	tsk = current;
 	mm = tsk->mm;
 
-	/*
-	 * Detect and handle instructions that would cause a page fault for
-	 * both a tracked kernel page and a userspace page.
-	 */
 	prefetchw(&mm->mmap_sem);
 
 	if (unlikely(kmmio_fault(regs, address)))
Signature · 1 line
2.16.1.291.g4437f3f132-goog
#1 lore raw

[tip:x86/pti] x86/mm: Remove stale comment about KMEMCHECK

x86/mm: Remove stale comment about KMEMCHECK
Commit-ID:  3b3a9268bba62b35a29bafe0931715b1725fdf26
Gitweb:     https://git.kernel.org/tip/3b3a9268bba62b35a29bafe0931715b1725fdf26
Author:     Jann Horn <[email protected]>
AuthorDate: Mon, 19 Feb 2018 18:50:39 +0100
Committer:  Ingo Molnar <[email protected]>
CommitDate: Tue, 20 Feb 2018 09:33:39 +0100

x86/mm: Remove stale comment about KMEMCHECK

This comment referred to a conditional call to kmemcheck_hide() that was here until commit 4950276672fc ("kmemcheck: remove annotations").

Now that kmemcheck has been removed, it doesn't make sense anymore.

Cc Andy Lutomirski <[email protected]>
Cc Borislav Petkov <[email protected]>
Cc Brian Gerst <[email protected]>
Cc Denys Vlasenko <[email protected]>
Cc H. Peter Anvin <[email protected]>
Cc Josh Poimboeuf <[email protected]>
Cc Linus Torvalds <[email protected]>
Cc Peter Zijlstra <[email protected]>
---
 arch/x86/mm/fault.c | 4 ----
 1 file changed, 4 deletions(-)
arch/x86/mm/fault.c +0 -4
index 800de81..c88573d 100644
@@ -1248,10 +1248,6 @@ __do_page_fault(struct pt_regs *regs, unsigned long error_code,
 	tsk = current;
 	mm = tsk->mm;
 
-	/*
-	 * Detect and handle instructions that would cause a page fault for
-	 * both a tracked kernel page and a userspace page.
-	 */
 	prefetchw(&mm->mmap_sem);
 
 	if (unlikely(kmmio_fault(regs, address)))