Skip to contentSkip to conversation

ntp: Make time_adjust static

PATCH In review John Stultz 1 participant 4 messages Mar 19, 2010 – Mar 23, 2010 Timekeeping, clocksource core, NTP, alarmtimer

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ntp: Make time_adjust static

Now that no arches are accessing time_adjust directly, make it static.

CC Thomas Gleixner <[email protected]>
---
 include/linux/timex.h |    1 -
 kernel/time/ntp.c     |    2 +-
 2 files changed, 1 insertions(+), 2 deletions(-)
include/linux/timex.h +0 -1
index 7a082b3..e2de51e 100644
@@ -238,7 +238,6 @@ extern int tickadj;			/* amount of adjustment per tick */
  * phase-lock loop variables
  */
 extern int time_status;		/* clock synchronization status bits */
-extern long time_adjust;	/* The amount of adjtime left */
 
 extern void ntp_init(void);
 extern void ntp_clear(void);
kernel/time/ntp.c +1 -1
index 7c0f180..c631168 100644
@@ -69,7 +69,7 @@ static s64			time_freq;
 /* time at last adjustment (secs):					*/
 static long			time_reftime;
 
-long				time_adjust;
+static long			time_adjust;
 
 /* constant (boot-param configurable) NTP tick adjustment (upscaled)	*/
 static s64			ntp_tick_adj;
Signature · 1 line
1.6.0.4
#1 lore raw

PATCH 1/1 ntp: Remove tickadj

There are zero users of tickadj. So remove it.

CC Thomas Gleixner <[email protected]>
---
 include/linux/timex.h |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)
include/linux/timex.h +0 -4
index e2de51e..32d852f 100644
@@ -232,7 +232,6 @@ struct timex {
  */
 extern unsigned long tick_usec;		/* USER_HZ period (usec) */
 extern unsigned long tick_nsec;		/* ACTHZ          period (nsec) */
-extern int tickadj;			/* amount of adjustment per tick */
 
 /*
  * phase-lock loop variables
@@ -270,9 +269,6 @@ extern void second_overflow(void);
 extern void update_ntp_one_tick(void);
 extern int do_adjtimex(struct timex *);
 
-/* Don't use! Compatibility define for existing users. */
-#define tickadj	(500/HZ ? : 1)
-
 int read_current_timer(unsigned long *timer_val);
 
 /* The clock frequency of the i8253/i8254 PIT */
Signature · 1 line
1.6.0.4
#2 lore raw

[tip:timers/core] ntp: Remove tickadj

Commit-ID:  3d0205bd1383aa3cac93c209b7c7d03b27930195
Gitweb:     http://git.kernel.org/tip/3d0205bd1383aa3cac93c209b7c7d03b27930195
Author:     John Stultz <[email protected]>
AuthorDate: Thu, 18 Mar 2010 20:19:28 -0700
Committer:  Thomas Gleixner <[email protected]>
CommitDate: Tue, 23 Mar 2010 17:19:38 +0100

ntp: Remove tickadj

There are zero users of tickadj. So remove it.

LKML-Reference: <[email protected]>

---
 include/linux/timex.h |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)
include/linux/timex.h +0 -4
index e2de51e..32d852f 100644
@@ -232,7 +232,6 @@ struct timex {
  */
 extern unsigned long tick_usec;		/* USER_HZ period (usec) */
 extern unsigned long tick_nsec;		/* ACTHZ          period (nsec) */
-extern int tickadj;			/* amount of adjustment per tick */
 
 /*
  * phase-lock loop variables
@@ -270,9 +269,6 @@ extern void second_overflow(void);
 extern void update_ntp_one_tick(void);
 extern int do_adjtimex(struct timex *);
 
-/* Don't use! Compatibility define for existing users. */
-#define tickadj	(500/HZ ? : 1)
-
 int read_current_timer(unsigned long *timer_val);
 
 /* The clock frequency of the i8253/i8254 PIT */
#3 lore raw
In reply to John Stultz
Commit-ID:  e1292ba164742e3a236e407148e00300b7196906
Gitweb:     http://git.kernel.org/tip/e1292ba164742e3a236e407148e00300b7196906
Author:     John Stultz <[email protected]>
AuthorDate: Thu, 18 Mar 2010 20:19:27 -0700
Committer:  Thomas Gleixner <[email protected]>
CommitDate: Tue, 23 Mar 2010 17:19:37 +0100

ntp: Make time_adjust static

Now that no arches are accessing time_adjust directly, make it static.

LKML-Reference: <[email protected]>

---
 include/linux/timex.h |    1 -
 kernel/time/ntp.c     |    2 +-
 2 files changed, 1 insertions(+), 2 deletions(-)
include/linux/timex.h +0 -1
index 7a082b3..e2de51e 100644
@@ -238,7 +238,6 @@ extern int tickadj;			/* amount of adjustment per tick */
  * phase-lock loop variables
  */
 extern int time_status;		/* clock synchronization status bits */
-extern long time_adjust;	/* The amount of adjtime left */
 
 extern void ntp_init(void);
 extern void ntp_clear(void);
kernel/time/ntp.c +1 -1
index 7c0f180..c631168 100644
@@ -69,7 +69,7 @@ static s64			time_freq;
 /* time at last adjustment (secs):					*/
 static long			time_reftime;
 
-long				time_adjust;
+static long			time_adjust;
 
 /* constant (boot-param configurable) NTP tick adjustment (upscaled)	*/
 static s64			ntp_tick_adj;