Skip to contentSkip to conversation

perf top: Don't use globals where not needed to

tip:perf/urgent tip-bot for Arnaldo Carvalho de Melo 1 participant 1 message Oct 5, 2012 perf events

lore
Share & tools
lore
#0 lore raw
Commit-ID:  be77284226374c75583f36dbbf43203039f6a44c
Gitweb:     http://git.kernel.org/tip/be77284226374c75583f36dbbf43203039f6a44c
Author:     Arnaldo Carvalho de Melo <[email protected]>
AuthorDate: Mon, 1 Oct 2012 15:20:58 -0300
Committer:  Arnaldo Carvalho de Melo <[email protected]>
CommitDate: Tue, 2 Oct 2012 18:36:38 -0300

perf top: Don't use globals where not needed to

Some variables were global but used in just one function, so move it to where it belongs.

Cc David Ahern <[email protected]>
Cc Frederic Weisbecker <[email protected]>
Cc Jiri Olsa <[email protected]>
Cc Mike Galbraith <[email protected]>
Cc Namhyung Kim <[email protected]>
Cc Paul Mackerras <[email protected]>
Cc Peter Zijlstra <[email protected]>
Cc Stephane Eranian <[email protected]>
---
 tools/perf/builtin-top.c |    9 ++++-----
 1 files changed, 4 insertions(+), 5 deletions(-)
tools/perf/builtin-top.c +4 -5
index e434a16..f0c1c4f 100644
@@ -1159,11 +1159,6 @@ setup:
 	return 0;
 }
 
-static const char * const top_usage[] = {
-	"perf top [<options>]",
-	NULL
-};
-
 int cmd_top(int argc, const char **argv, const char *prefix __maybe_unused)
 {
 	struct perf_evsel *pos;
@@ -1250,6 +1245,10 @@ int cmd_top(int argc, const char **argv, const char *prefix __maybe_unused)
 	OPT_STRING('u', "uid", &top.target.uid_str, "user", "user to profile"),
 	OPT_END()
 	};
+	const char * const top_usage[] = {
+		"perf top [<options>]",
+		NULL
+	};
 
 	top.evlist = perf_evlist__new(NULL, NULL);
 	if (top.evlist == NULL)