Skip to contentSkip to conversation

perf_counter tools: Small frequency related fixes

tip:perfcounters/core tip-bot for Peter Zijlstra 1 participant 1 message Jun 10, 2009 perf events

lore
Share & tools
lore
#0 lore raw
Commit-ID:  4502d77c1d8f15f20c04b92cb96c12d4e465de29
Gitweb:     http://git.kernel.org/tip/4502d77c1d8f15f20c04b92cb96c12d4e465de29
Author:     Peter Zijlstra <[email protected]>
AuthorDate: Wed, 10 Jun 2009 15:03:06 +0200
Committer:  Ingo Molnar <[email protected]>
CommitDate: Wed, 10 Jun 2009 16:55:26 +0200

perf_counter tools: Small frequency related fixes

Create the counter in a disabled state and only enable it after we mmap() the buffer, this allows us to see the first few samples (and observe the frequency ramp).

Furthermore, print the period in the verbose report.

Cc Mike Galbraith <[email protected]>
Cc Paul Mackerras <[email protected]>
Cc Arnaldo Carvalho de Melo <[email protected]>

LKML-Reference: <new-submission>

---
 tools/perf/builtin-record.c |    3 +++
 tools/perf/builtin-report.c |    6 ++++--
 2 files changed, 7 insertions(+), 2 deletions(-)
tools/perf/builtin-record.c +3 -0
index deaee42..a5698ad 100644
@@ -347,6 +347,7 @@ static void create_counter(int counter, int cpu, pid_t pid)
 	attr->mmap		= track;
 	attr->comm		= track;
 	attr->inherit		= (cpu < 0) && inherit;
+	attr->disabled		= 1;
 
 	track = 0; /* only the first counter needs these */
 
@@ -402,6 +403,8 @@ try_again:
 		error("failed to mmap with %d (%s)\n", errno, strerror(errno));
 		exit(-1);
 	}
+
+	ioctl(fd[nr_cpu][counter], PERF_COUNTER_IOC_ENABLE);
 }
 
 static void open_counters(int cpu, pid_t pid)
tools/perf/builtin-report.c +4 -2
index 0b18cb9..9a0e31e 100644
@@ -47,6 +47,7 @@ struct ip_event {
 	struct perf_event_header header;
 	__u64 ip;
 	__u32 pid, tid;
+	__u64 period;
 };
 
 struct mmap_event {
@@ -943,12 +944,13 @@ process_overflow_event(event_t *event, unsigned long offset, unsigned long head)
 	uint64_t ip = event->ip.ip;
 	struct map *map = NULL;
 
-	dprintf("%p [%p]: PERF_EVENT (IP, %d): %d: %p\n",
+	dprintf("%p [%p]: PERF_EVENT (IP, %d): %d: %p period: %Ld\n",
 		(void *)(offset + head),
 		(void *)(long)(event->header.size),
 		event->header.misc,
 		event->ip.pid,
-		(void *)(long)ip);
+		(void *)(long)ip,
+		(long long)event->ip.period);
 
 	dprintf(" ... thread: %s:%d\n", thread->comm, thread->pid);