x86: pci-swiotlb.c swiotlb_dma_ops should be static
PATCH 1/1 x86: pci-swiotlb.c swiotlb_dma_ops should be static
Impact: reduce kernel size a bit, address sparse warning
Addresses the problem pointed out by this sparse warning:
arch/x86/kernel/pci-swiotlb.c:53:20: warning: symbol 'swiotlb_dma_ops' was not declared. Should it be static?
For x86: swiotlb_dma_ops can be static, because it's not used outside pci-swiotlb.c
--- arch/x86/kernel/pci-swiotlb.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
arch/x86/kernel/pci-swiotlb.c +1 -1
@@ -50,7 +50,7 @@ static void *x86_swiotlb_alloc_coherent(struct device *hwdev, size_t size,return swiotlb_alloc_coherent (hwdev, size, dma_handle, flags); } -struct dma_map_ops swiotlb_dma_ops = { +static struct dma_map_ops swiotlb_dma_ops = { .mapping_error = swiotlb_dma_mapping_error, .alloc_coherent = x86_swiotlb_alloc_coherent, .free_coherent = swiotlb_free_coherent,
Signature · 1 line
1.6.0.6
Commit-ID: 49cc21f93ddc4c17c2be77d9da43a2db69acc0d3 Gitweb: http://git.kernel.org/tip/49cc21f93ddc4c17c2be77d9da43a2db69acc0d3 Author: Jaswinder Singh Rajput <[email protected]> AuthorDate: Sun, 12 Apr 2009 23:24:21 +0530 Committer: Ingo Molnar <[email protected]> CommitDate: Tue, 14 Apr 2009 01:35:11 +0200
x86: pci-swiotlb.c swiotlb_dma_ops should be static
Impact: reduce kernel size a bit, address sparse warning
Addresses the problem pointed out by this sparse warning:
arch/x86/kernel/pci-swiotlb.c:53:20: warning: symbol 'swiotlb_dma_ops' was not declared. Should it be static?
For x86: swiotlb_dma_ops can be static, because it's not used outside of pci-swiotlb.c
LKML-Reference: <[email protected]>
--- arch/x86/kernel/pci-swiotlb.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
arch/x86/kernel/pci-swiotlb.c +1 -1
@@ -50,7 +50,7 @@ static void *x86_swiotlb_alloc_coherent(struct device *hwdev, size_t size,return swiotlb_alloc_coherent (hwdev, size, dma_handle, flags); } -struct dma_map_ops swiotlb_dma_ops = { +static struct dma_map_ops swiotlb_dma_ops = { .mapping_error = swiotlb_dma_mapping_error, .alloc_coherent = x86_swiotlb_alloc_coherent, .free_coherent = swiotlb_free_coherent,
FUJITA Tomonori
Acked-byQuoted 15 lines · On Tue, 14 Apr 2009 00:12:52 GMT tip-bot for Jaswinder Singh Rajput…
Commit-ID: 49cc21f93ddc4c17c2be77d9da43a2db69acc0d3 Gitweb: http://git.kernel.org/tip/49cc21f93ddc4c17c2be77d9da43a2db69acc0d3 Author: Jaswinder Singh Rajput <[email protected]> AuthorDate: Sun, 12 Apr 2009 23:24:21 +0530 Committer: Ingo Molnar <[email protected]> CommitDate: Tue, 14 Apr 2009 01:35:11 +0200x86:
pci-swiotlb.cswiotlb_dma_opsshould be staticImpact: reduce kernel size a bit, address sparse warning
Addresses the problem pointed out by this sparse warning:
arch/x86/kernel/pci-swiotlb.c:53:20: warning: symbol 'swiotlb_dma_ops' was not declared. Should it be static?
Quoted 7 lines
For x86:
swiotlb_dma_opscan be static, because it's not used outside ofpci-swiotlb.cSigned-off-by Jaswinder Singh Rajput <[email protected]>Cc FUJITA Tomonori <[email protected]>LKML-Reference: <[email protected]>
Signed-off-by Ingo Molnar <[email protected]>
Well, this patch is fine for now. But all the users of swiotlb uses struct dma_map_ops now so I plan to remove the arch's dma_map_ops swiotlb_dma_ops.
Quoted 23 lines
--- arch/x86/kernel/pci-swiotlb.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)arch/x86/kernel/pci-swiotlb.c +1
-2@@ -50,7 +50,7 @@ static void *x86_swiotlb_alloc_coherent(struct device *hwdev, size_t size,return swiotlb_alloc_coherent (hwdev, size, dma_handle, flags); } -struct dma_map_ops swiotlb_dma_ops = { +static struct dma_map_ops swiotlb_dma_ops = { .mapping_error = swiotlb_dma_mapping_error, .alloc_coherent = x86_swiotlb_alloc_coherent, .free_coherent = swiotlb_free_coherent, --To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Commit-ID: ff6c6fed3a8ab9b0a7b02574e095e905e89421d9 Gitweb: http://git.kernel.org/tip/ff6c6fed3a8ab9b0a7b02574e095e905e89421d9 Author: Jaswinder Singh Rajput <[email protected]> AuthorDate: Sun, 12 Apr 2009 23:24:21 +0530 Committer: Ingo Molnar <[email protected]> CommitDate: Tue, 14 Apr 2009 02:51:04 +0200
x86: pci-swiotlb.c swiotlb_dma_ops should be static
Impact: reduce kernel size a bit, address sparse warning
Addresses the problem pointed out by this sparse warning:
arch/x86/kernel/pci-swiotlb.c:53:20: warning: symbol 'swiotlb_dma_ops' was not declared. Should it be static?
For x86: swiotlb_dma_ops can be static, because it's not used outside of pci-swiotlb.c
LKML-Reference: <[email protected]>
--- arch/x86/kernel/pci-swiotlb.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
arch/x86/kernel/pci-swiotlb.c +1 -1
@@ -50,7 +50,7 @@ static void *x86_swiotlb_alloc_coherent(struct device *hwdev, size_t size,return swiotlb_alloc_coherent (hwdev, size, dma_handle, flags); } -struct dma_map_ops swiotlb_dma_ops = { +static struct dma_map_ops swiotlb_dma_ops = { .mapping_error = swiotlb_dma_mapping_error, .alloc_coherent = x86_swiotlb_alloc_coherent, .free_coherent = swiotlb_free_coherent,