Skip to contentSkip to conversation

linux-next: tip tree build warning

PATCH In review Stephen Rothwell 2 participants 4 messages Feb 1, 2010 – Feb 2, 2010 Linux-next tree

lore
Share & tools
lore
#0 lore raw

Hi all,

Today's linux-next build (powerpc allyesconfig) produced this warning:

kernel/sched.c:1636: warning: 'update_shares_locked' defined but not used

Introduced by commit f492e12ef050e02bf0185b6b57874992591b9be1 ("sched:
Remove load_balance_newidle()").

Signature · 3 lines
Cheers,
Stephen Rothwell                    [email protected]
http://www.canb.auug.org.au/~sfr/
#1 lore raw

PATCH 1/1 sched: Remove unused update_shares_locked()

Quoted 8 lines · Stephen Rothwell

Hi all,

Today's linux-next build (powerpc allyesconfig) produced this warning:

kernel/sched.c:1636: warning: 'update_shares_locked' defined but not used

Introduced by commit f492e12ef050e02bf0185b6b57874992591b9be1 ("sched:
Remove load_balance_newidle()").

Hmm, you're quite right indeed, that removed the only user of that function.

---
Subject: sched: Remove unused update_shares_locked()

Commit f492e12ef050e02bf0185b6b57874992591b9be1 ("sched: Remove load_balance_newidle()") removed the only user of this function, so remove it too.

---
 kernel/sched.c |   14 --------------
 1 files changed, 0 insertions(+), 14 deletions(-)
kernel/sched.c +0 -14
index 876e7c1..b5c8b44 100644
@@ -1633,16 +1633,6 @@ static void update_shares(struct sched_domain *sd)
 	}
 }
 
-static void update_shares_locked(struct rq *rq, struct sched_domain *sd)
-{
-	if (root_task_group_empty())
-		return;
-
-	raw_spin_unlock(&rq->lock);
-	update_shares(sd);
-	raw_spin_lock(&rq->lock);
-}
-
 static void update_h_load(long cpu)
 {
 	if (root_task_group_empty())
@@ -1657,10 +1647,6 @@ static inline void update_shares(struct sched_domain *sd)
 {
 }
 
-static inline void update_shares_locked(struct rq *rq, struct sched_domain *sd)
-{
-}
-
 #endif
 
 #ifdef CONFIG_PREEMPT
#2 lore raw

Re: [PATCH] sched: Remove unused update_shares_locked()

Hi Peter,

Quoted 2 lines · On Mon, 01 Feb 2010 11:13:39 +0100 Peter Zijlstra <[email protected]> wrote:

Subject: sched: Remove unused update_shares_locked()

Thanks for that.

Signature · 3 lines
Cheers,
Stephen Rothwell                    [email protected]
http://www.canb.auug.org.au/~sfr/
#3 lore raw

[tip:sched/core] sched: Remove unused update_shares_locked()

In reply to Peter Zijlstra
Commit-ID:  4a461c85b643258e305eb5a3aced34009db2f818
Gitweb:     http://git.kernel.org/tip/4a461c85b643258e305eb5a3aced34009db2f818
Author:     Peter Zijlstra <[email protected]>
AuthorDate: Mon, 1 Feb 2010 11:13:39 +0100
Committer:  Ingo Molnar <[email protected]>
CommitDate: Tue, 2 Feb 2010 06:58:27 +0100

sched: Remove unused update_shares_locked()

Commit f492e12ef050e02bf0185b6b57874992591b9be1 ("sched: Remove load_balance_newidle()") removed the only user of this function, so remove it too.

LKML-Reference: <1265019219.24455.128.camel@laptop>

---
 kernel/sched.c |   14 --------------
 1 files changed, 0 insertions(+), 14 deletions(-)
kernel/sched.c +0 -14
index a56ead4..2386f54 100644
@@ -1633,16 +1633,6 @@ static void update_shares(struct sched_domain *sd)
 	}
 }
 
-static void update_shares_locked(struct rq *rq, struct sched_domain *sd)
-{
-	if (root_task_group_empty())
-		return;
-
-	raw_spin_unlock(&rq->lock);
-	update_shares(sd);
-	raw_spin_lock(&rq->lock);
-}
-
 static void update_h_load(long cpu)
 {
 	if (root_task_group_empty())
@@ -1657,10 +1647,6 @@ static inline void update_shares(struct sched_domain *sd)
 {
 }
 
-static inline void update_shares_locked(struct rq *rq, struct sched_domain *sd)
-{
-}
-
 #endif
 
 #ifdef CONFIG_PREEMPT