Skip to contentSkip to conversation

perf tools: Print a newline when dumping PERF_RECORD_FINISHED_ROUND

PATCH New Adrian Hunter 2 participants 4 messages Jun 23, 2015 – Jun 25, 2015 perf events

lore
Share & tools
lore

Adrian Hunter

author reviewer
#0 lore raw

PATCH 1/2 perf tools: Print a newline when dumping PERF_RECORD_FINISHED_ROUND

With 'perf report -D' the PERF_RECORD_FINISHED_ROUND event was printed without a newline, resulting in:

	0x91a18 [0x8]: PERF_RECORD_FINISHED_ROUNDAggregated stats

Other events print their details, but PERF_RECORD_FINISHED_ROUND doesn't have any so just add a print for a newline.

Signed-off-by Adrian Hunter <[email protected]>
---
 tools/perf/util/session.c | 2 ++
 1 file changed, 2 insertions(+)
tools/perf/util/session.c +2 -0
index aa482c10469d..aac1c4cee1e8 100644
@@ -686,6 +686,8 @@ static int process_finished_round(struct perf_tool *tool __maybe_unused,
 				  union perf_event *event __maybe_unused,
 				  struct ordered_events *oe)
 {
+	if (dump_trace)
+		fprintf(stdout, "\n");
 	return ordered_events__flush(oe, OE_FLUSH__ROUND);
 }
Signature · 1 line
1.9.1
author reviewer
#1 lore raw

PATCH 2/2 perf tools: Print a newline before dumping Aggregated stats

When dumping events with 'perf report -D' the event print always starts with a newline (see dump_event()). Do the same with the "Aggregated stats" print so that it is not jammed up against the last event print.

Signed-off-by Adrian Hunter <[email protected]>
---
 tools/perf/util/session.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/perf/util/session.c +1 -1
index aac1c4cee1e8..b5549b58bb2b 100644
@@ -1728,7 +1728,7 @@ size_t perf_session__fprintf_nr_events(struct perf_session *session, FILE *fp)
 	if (perf_header__has_feat(&session->header, HEADER_AUXTRACE))
 		msg = " (excludes AUX area (e.g. instruction trace) decoded / synthesized events)";
 
-	ret = fprintf(fp, "Aggregated stats:%s\n", msg);
+	ret = fprintf(fp, "\nAggregated stats:%s\n", msg);
 
 	ret += events_stats__fprintf(&session->evlist->stats, fp);
 	return ret;
Signature · 1 line
1.9.1
merge bot
#2 lore raw

[tip:perf/core] perf tools: Print a newline before dumping Aggregated stats

perf tools: Print a newline before dumping Aggregated stats
Commit-ID:  fe692ac86adbbbbf9745909aafe0c87fd7fc6368
Gitweb:     http://git.kernel.org/tip/fe692ac86adbbbbf9745909aafe0c87fd7fc6368
Author:     Adrian Hunter <[email protected]>
AuthorDate: Tue, 23 Jun 2015 10:52:49 +0300
Committer:  Arnaldo Carvalho de Melo <[email protected]>
CommitDate: Tue, 23 Jun 2015 18:21:43 -0300

perf tools: Print a newline before dumping Aggregated stats

When dumping events with 'perf report -D' the event print always starts with a newline (see dump_event()).

Do the same with the "Aggregated stats" print so that it is not jammed up against the last event print.

Signed-off-by Adrian Hunter <[email protected]>
Cc Jiri Olsa <[email protected]>
Link http://lkml.kernel.org/r/[email protected] open here
Signed-off-by Arnaldo Carvalho de Melo <[email protected]>
---
 tools/perf/util/session.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/perf/util/session.c +1 -1
index aac1c4c..b5549b5 100644
@@ -1728,7 +1728,7 @@ size_t perf_session__fprintf_nr_events(struct perf_session *session, FILE *fp)
 	if (perf_header__has_feat(&session->header, HEADER_AUXTRACE))
 		msg = " (excludes AUX area (e.g. instruction trace) decoded / synthesized events)";
 
-	ret = fprintf(fp, "Aggregated stats:%s\n", msg);
+	ret = fprintf(fp, "\nAggregated stats:%s\n", msg);
 
 	ret += events_stats__fprintf(&session->evlist->stats, fp);
 	return ret;
merge bot
#3 lore raw

[tip:perf/core] perf session: Print a newline when dumping PERF_RECORD_FINISHED_ROUND

In reply to Adrian Hunter
perf session: Print a newline when dumping PERF_RECORD_FINISHED_ROUND
Commit-ID:  5531e16227cc18bc13b028a052a609a233b49c07
Gitweb:     http://git.kernel.org/tip/5531e16227cc18bc13b028a052a609a233b49c07
Author:     Adrian Hunter <[email protected]>
AuthorDate: Tue, 23 Jun 2015 10:52:48 +0300
Committer:  Arnaldo Carvalho de Melo <[email protected]>
CommitDate: Tue, 23 Jun 2015 18:21:43 -0300

perf session: Print a newline when dumping PERF_RECORD_FINISHED_ROUND

With 'perf report -D' the PERF_RECORD_FINISHED_ROUND event was printed without a newline, resulting in:

	0x91a18 [0x8]: PERF_RECORD_FINISHED_ROUNDAggregated stats

Other events print their details, but PERF_RECORD_FINISHED_ROUND doesn't have any so just add a print for a newline.

Signed-off-by Adrian Hunter <[email protected]>
Cc Jiri Olsa <[email protected]>
Link http://lkml.kernel.org/r/[email protected] open here
Signed-off-by Arnaldo Carvalho de Melo <[email protected]>
---
 tools/perf/util/session.c | 2 ++
 1 file changed, 2 insertions(+)
tools/perf/util/session.c +2 -0
index aa482c1..aac1c4c 100644
@@ -686,6 +686,8 @@ static int process_finished_round(struct perf_tool *tool __maybe_unused,
 				  union perf_event *event __maybe_unused,
 				  struct ordered_events *oe)
 {
+	if (dump_trace)
+		fprintf(stdout, "\n");
 	return ordered_events__flush(oe, OE_FLUSH__ROUND);
 }