perf tools: Just pr_debug() about not being able to read cacheline_size

tip:perf/core tip-bot for Arnaldo Carvalho de Melo 1 participant 1 message Jul 16, 2016 perf events

Share & tools

tip-bot for Arnaldo Carvalho de Melo

author merge bot

2016-07-16 20:44 UTC #0 lore raw

Commit-ID:  8811e8ea14c1056b09c794c67836b8a84584ddef
Gitweb:     http://git.kernel.org/tip/8811e8ea14c1056b09c794c67836b8a84584ddef
Author:     Arnaldo Carvalho de Melo <[email protected]>
AuthorDate: Fri, 15 Jul 2016 10:05:19 -0300
Committer:  Arnaldo Carvalho de Melo <[email protected]>
CommitDate: Fri, 15 Jul 2016 10:08:29 -0300

perf tools: Just pr_debug() about not being able to read cacheline_size

So far the cacheline_size is only useful for the "dcacheline" --sort order, i.e. if that is not used, which is the norm, then the user shouldn't care that he is running this, say, on an Android system where sysconf(_SC_LEVEL1_DCACHE_LINESIZE) and the /sys/devices/system/cpu/cpu0/cache/index0/coherency_line_size sysfs file isn't available.

An upcoming patch will emit an warning only for "--sort ...,dcacheline,...".

Cc Adrian Hunter <[email protected]>

Cc Chris Phlipot <[email protected]>

Cc David Ahern <[email protected]>

Cc Jiri Olsa <[email protected]>

Cc Namhyung Kim <[email protected]>

Cc Wang Nan <[email protected]>

Link http://lkml.kernel.org/n/[email protected] open here

Signed-off-by Arnaldo Carvalho de Melo <[email protected]>

---
 tools/perf/perf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

tools/perf/perf.c +1 -1

index 4b2ff02..64c0696 100644
@@ -503,7 +503,7 @@ void pthread__unblock_sigwinch(void)
 static void cache_line_size(int *cacheline_sizep)
 {
 	if (sysfs__read_int("devices/system/cpu/cpu0/cache/index0/coherency_line_size", cacheline_sizep))
-		perror("cannot determine cache line size");
+		pr_debug("cannot determine cache line size");
 }
 #endif