sched/deadline: fix runtime accounting in documentation
PATCH v2 1/1 sched/deadline: fix runtime accounting in documentation
Signed-off-by Claudio Scordino <[email protected]>
Signed-off-by Luca Abeni <[email protected]>
CC Jonathan Corbet <[email protected]>
CC "Peter Zijlstra (Intel)" <[email protected]>
CC Ingo Molnar <[email protected]>
Cc Tommaso Cucinotta <[email protected]>
Cc Mathieu Poirier <[email protected]>
--- Documentation/scheduler/sched-deadline.txt | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-)
Documentation/scheduler/sched-deadline.txt +10 -3
@@ -204,10 +204,17 @@ CONTENTS It does so by decrementing the runtime of the executing task Ti at a pace equal to - dq = -max{ Ui, (1 - Uinact) } dt + dq = -max{ Ui / Umax, (1 - Uinact - Uextra) } dt - where Uinact is the inactive utilization, computed as (this_bq - running_bw), - and Ui is the bandwidth of task Ti. + where: + + - Ui is the bandwidth of task Ti; + - Umax is the maximum reclaimable utilization (subjected to RT throttling + limits); + - Uinact is the (per runqueue) inactive utilization, computed as + (this_bq - running_bw); + - Uextra is the (per runqueue) extra reclaimable utilization + (subjected to RT throttling limits). Let's now see a trivial example of two deadline tasks with runtime equal
Signature · 1 line
2.7.4
Hi Claudio,
Quoted 10 lines · Claudio Scordino
Signed-off-by Claudio Scordino <[email protected]>Signed-off-by Luca Abeni <[email protected]>CC Jonathan Corbet <[email protected]>CC "Peter Zijlstra (Intel)" <[email protected]>CC Ingo Molnar <[email protected]>Cc Tommaso Cucinotta <[email protected]>Cc Mathieu Poirier <[email protected]>---
Please add a short description for your change, even if it is trivial.
Quoted 15 lines
Documentation/scheduler/sched-deadline.txt | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-)Documentation/scheduler/sched-deadline.txt +1
-2@@ -204,10 +204,17 @@ CONTENTS It does so by decrementing the runtime of the executing task Ti at a pace equal to - dq = -max{ Ui, (1 - Uinact) } dt + dq = -max{ Ui / Umax, (1 - Uinact - Uextra) } dt - where Uinact is the inactive utilization, computed as (this_bq - running_bw),
Documentation/scheduler/sched-deadline.txt CONTENTS · line 217
Quoted 10 lines
Documentation/scheduler/sched-deadline.txt +9
-1- and Ui is the bandwidth of task Ti. + where: + + - Ui is the bandwidth of task Ti; + - Umax is the maximum reclaimable utilization (subjected to RT throttling + limits); + - Uinact is the (per runqueue) inactive utilization, computed as + (this_bq - running_bw); + - Uextra is the (per runqueue) extra reclaimable utilization + (subjected to RT throttling limits).
I think there would be value in defining 'dq' and 'dt'. That way people know exactly what they are and it leaves no room for interpretation.
Thanks,
Mathieu
Quoted 6 lines
Documentation/scheduler/sched-deadline.txt +0
-1Let's now see a trivial example of two deadline tasks with runtime equal --2.7.4
Quoted 9 lines · Claudio Scordino
Signed-off-by Claudio Scordino <[email protected]>Signed-off-by Luca Abeni <[email protected]>CC Jonathan Corbet <[email protected]>CC "Peter Zijlstra (Intel)" <[email protected]>CC Ingo Molnar <[email protected]>Cc Tommaso Cucinotta <[email protected]>Cc Mathieu Poirier <[email protected]>
ACK, Ingo can you route this?
Quoted 32 lines
--- Documentation/scheduler/sched-deadline.txt | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-)Documentation/scheduler/sched-deadline.txt +10
-3@@ -204,10 +204,17 @@ CONTENTS It does so by decrementing the runtime of the executing task Ti at a pace equal to - dq = -max{ Ui, (1 - Uinact) } dt + dq = -max{ Ui / Umax, (1 - Uinact - Uextra) } dt - where Uinact is the inactive utilization, computed as (this_bq - running_bw), - and Ui is the bandwidth of task Ti. + where: + + - Ui is the bandwidth of task Ti; + - Umax is the maximum reclaimable utilization (subjected to RT throttling + limits); + - Uinact is the (per runqueue) inactive utilization, computed as + (this_bq - running_bw); + - Uextra is the (per runqueue) extra reclaimable utilization + (subjected to RT throttling limits). Let's now see a trivial example of two deadline tasks with runtime equalSignature · 1 line
2.7.4
Quoted 11 lines · Peter Zijlstra
Quoted 9 lines · Claudio Scordino
Signed-off-by Claudio Scordino <[email protected]>Signed-off-by Luca Abeni <[email protected]>CC Jonathan Corbet <[email protected]>CC "Peter Zijlstra (Intel)" <[email protected]>CC Ingo Molnar <[email protected]>Cc Tommaso Cucinotta <[email protected]>Cc Mathieu Poirier <[email protected]>
Quoted 1 line
ACK, Ingo can you route this?
Yeah, I've applied it to tip:sched/urgent, should go upstream in a few days.
Thanks,
Ingo
tip-bot for Claudio Scordino
merge bot[tip:sched/urgent] sched/deadline: Fix the description of runtime accounting in the documentation
In reply to Claudio Scordinosched/deadline: Fix the description of runtime accounting in the documentation
Commit-ID: 5c0342ca7ef17220d8dd2da68d0d349c26ab19df Gitweb: https://git.kernel.org/tip/5c0342ca7ef17220d8dd2da68d0d349c26ab19df Author: Claudio Scordino <[email protected]> AuthorDate: Tue, 14 Nov 2017 12:19:26 +0100 Committer: Ingo Molnar <[email protected]> CommitDate: Thu, 16 Nov 2017 09:00:35 +0100
sched/deadline: Fix the description of runtime accounting in the documentation
Signed-off-by Claudio Scordino <[email protected]>
Signed-off-by Luca Abeni <[email protected]>
Acked-by Peter Zijlstra <[email protected]>
Cc Jonathan Corbet <[email protected]>
Cc Linus Torvalds <[email protected]>
Cc Mathieu Poirier <[email protected]>
Cc Thomas Gleixner <[email protected]>
Cc Tommaso Cucinotta <[email protected]>
Signed-off-by Ingo Molnar <[email protected]>
--- Documentation/scheduler/sched-deadline.txt | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-)
Documentation/scheduler/sched-deadline.txt +10 -3
@@ -204,10 +204,17 @@ CONTENTS It does so by decrementing the runtime of the executing task Ti at a pace equal to - dq = -max{ Ui, (1 - Uinact) } dt + dq = -max{ Ui / Umax, (1 - Uinact - Uextra) } dt - where Uinact is the inactive utilization, computed as (this_bq - running_bw), - and Ui is the bandwidth of task Ti. + where: + + - Ui is the bandwidth of task Ti; + - Umax is the maximum reclaimable utilization (subjected to RT throttling + limits); + - Uinact is the (per runqueue) inactive utilization, computed as + (this_bq - running_bw); + - Uextra is the (per runqueue) extra reclaimable utilization + (subjected to RT throttling limits). Let's now see a trivial example of two deadline tasks with runtime equal