x86,apic - drop redundant bit assignment
PATCH 1/1 x86,apic - drop redundant bit assignment
cpu_has_apic has already investigated boot_cpu_data X86_FEATURE_APIC bit for being clear if condition is triggered. So there is no need to clear this bit second time.
---
Please review. Is there some unobvious reason was before to clear this bit? This snippet already here since long ago. Perhaps I miss something?
arch/x86/kernel/apic/apic.c | 1 - 1 file changed, 1 deletion(-)
arch/x86/kernel/apic/apic.c +0 -1
@@ -1651,7 +1651,6 @@ int __init APIC_init_uniprocessor(void) APIC_INTEGRATED(apic_version[boot_cpu_physical_apicid])) {pr_err ("BIOS bug, local APIC 0x%x not detected!...\n" , boot_cpu_physical_apicid); -clear_cpu_cap (&boot_cpu_data,X86_FEATURE_APIC );return -1 ; }#endif
[tip:x86/apic] x86, apic: Drop redundant bit assignment
Commit-ID: 5c0c5f2bcb98afd2af6eebad0b0b1f7ffd04d73a Gitweb: http://git.kernel.org/tip/5c0c5f2bcb98afd2af6eebad0b0b1f7ffd04d73a Author: Cyrill Gorcunov <[email protected]> AuthorDate: Thu, 23 Jul 2009 00:52:59 +0400 Committer: Ingo Molnar <[email protected]> CommitDate: Tue, 4 Aug 2009 16:35:45 +0200
x86, apic: Drop redundant bit assignment
cpu_has_apic has already investigated boot_cpu_data X86_FEATURE_APIC bit for being clear if condition is triggered.
So there is no need to clear this bit second time.
LKML-Reference: <20090722205259.GE15805@lenovo>
--- arch/x86/kernel/apic/apic.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-)
arch/x86/kernel/apic/apic.c +0 -1
@@ -1660,7 +1660,6 @@ int __init APIC_init_uniprocessor(void) APIC_INTEGRATED(apic_version[boot_cpu_physical_apicid])) {pr_err ("BIOS bug, local APIC 0x%x not detected!...\n" , boot_cpu_physical_apicid); -clear_cpu_cap (&boot_cpu_data,X86_FEATURE_APIC );return -1 ; }#endif
[tip:x86/apic] x86, apic: Drop redundant bit assignment
In reply to Cyrill GorcunovCommit-ID: 9910887af84e33ba98fd6792029470ae80166208 Gitweb: http://git.kernel.org/tip/9910887af84e33ba98fd6792029470ae80166208 Author: Cyrill Gorcunov <[email protected]> AuthorDate: Thu, 23 Jul 2009 00:52:59 +0400 Committer: Ingo Molnar <[email protected]> CommitDate: Wed, 5 Aug 2009 10:30:52 +0200
x86, apic: Drop redundant bit assignment
cpu_has_apic has already investigated boot_cpu_data X86_FEATURE_APIC bit for being clear if condition is triggered.
So there is no need to clear this bit second time.
LKML-Reference: <20090722205259.GE15805@lenovo>
--- arch/x86/kernel/apic/apic.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-)
arch/x86/kernel/apic/apic.c +0 -1
@@ -1651,7 +1651,6 @@ int __init APIC_init_uniprocessor(void) APIC_INTEGRATED(apic_version[boot_cpu_physical_apicid])) {pr_err ("BIOS bug, local APIC 0x%x not detected!...\n" , boot_cpu_physical_apicid); -clear_cpu_cap (&boot_cpu_data,X86_FEATURE_APIC );return -1 ; }#endif