Skip to contentSkip to conversation

x86, gcc-4.6: Avoid unused by set variables in rdmsr

tip:x86/gcc46 tip-bot for Andi Kleen 1 participant 1 message Jul 20, 2010 1 message not in the archive x86

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw
Commit-ID:  5f755293ca61520b70b11afe1b1d6e1635cb6c00
Gitweb:     http://git.kernel.org/tip/5f755293ca61520b70b11afe1b1d6e1635cb6c00
Author:     Andi Kleen <[email protected]>
AuthorDate: Tue, 20 Jul 2010 15:19:48 -0700
Committer:  H. Peter Anvin <[email protected]>
CommitDate: Tue, 20 Jul 2010 15:38:18 -0700

x86, gcc-4.6: Avoid unused by set variables in rdmsr

Avoids quite a lot of warnings with a gcc 4.6 -Wall build because this happens in a commonly used header file (apic.h)

LKML-Reference: <[email protected]>

---
 arch/x86/include/asm/msr.h |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
arch/x86/include/asm/msr.h +2 -2
index c5bc4c2..084ef95 100644
@@ -148,8 +148,8 @@ static inline unsigned long long native_read_pmc(int counter)
 #define rdmsr(msr, val1, val2)					\
 do {								\
 	u64 __val = native_read_msr((msr));			\
-	(val1) = (u32)__val;					\
-	(val2) = (u32)(__val >> 32);				\
+	(void)((val1) = (u32)__val);				\
+	(void)((val2) = (u32)(__val >> 32));			\
 } while (0)
 
 static inline void wrmsr(unsigned msr, unsigned low, unsigned high)