Skip to contentSkip to conversation

perf tools: Cast off_t to s64 to avoid warning on bionic libc

tip:perf/core tip-bot for Arnaldo Carvalho de Melo 1 participant 1 message Dec 20, 2018 perf events

lore
Share & tools
lore
#0 lore raw
Commit-ID:  866053bb644f754d1a93aaa9db9998fecf7a8978
Gitweb:     https://git.kernel.org/tip/866053bb644f754d1a93aaa9db9998fecf7a8978
Author:     Arnaldo Carvalho de Melo <[email protected]>
AuthorDate: Tue, 11 Dec 2018 16:43:40 -0300
Committer:  Arnaldo Carvalho de Melo <[email protected]>
CommitDate: Tue, 18 Dec 2018 12:23:57 -0300

perf tools: Cast off_t to s64 to avoid warning on bionic libc

To avoid this warning:

CC /tmp/build/perf/util/s390-cpumsf.o
util/s390-cpumsf.c: In function 's390_cpumsf_samples':
util/s390-cpumsf.c:508:3: warning: format '%llx' expects argument of type 'long long unsigned int', but argument 4 has type 'off_t' [-Wformat=]
pr_err("[%#08" PRIx64 "] Invalid AUX trailer entry TOD clock base\n",
^

Now the various Android cross toolchains used in the perf tools container test builds are all clean and we can remove this:

export EXTRA_MAKE_ARGS="WERROR=0"

---
 tools/perf/util/s390-cpumsf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/perf/util/s390-cpumsf.c +1 -1
index a2eeebbfb25f..68b2570304ec 100644
@@ -506,7 +506,7 @@ static int s390_cpumsf_samples(struct s390_cpumsf_queue *sfq, u64 *ts)
 	aux_ts = get_trailer_time(buf);
 	if (!aux_ts) {
 		pr_err("[%#08" PRIx64 "] Invalid AUX trailer entry TOD clock base\n",
-		       sfq->buffer->data_offset);
+		       (s64)sfq->buffer->data_offset);
 		aux_ts = ~0ULL;
 		goto out;
 	}