perf top browser: Adjust the browser indexes when refreshing
Commit-ID: 6435a5e39d3e01a1a73a925ed53ee18619b0a368 Gitweb: http://git.kernel.org/tip/6435a5e39d3e01a1a73a925ed53ee18619b0a368 Author: Arnaldo Carvalho de Melo <[email protected]> AuthorDate: Wed, 23 Feb 2011 07:25:02 -0300 Committer: Arnaldo Carvalho de Melo <[email protected]> CommitDate: Wed, 23 Feb 2011 07:25:02 -0300
perf top browser: Adjust the browser indexes when refreshing
This is not a problem when we're not at the bottom of the active symbols list, so was not noticed, but at the end of the screen it falls apart.
Fix it by adjusting the ui_browser indexes according to the new number of entries in the rb_tree and by seeking from the start of the rb_tree to find the new symbol at the top of the screen.
Cc: Frederic Weisbecker <[email protected]>
Cc: Ingo Molnar <[email protected]>
Cc: Mike Galbraith <[email protected]>
Cc: Paul Mackerras <[email protected]>
Cc: Peter Zijlstra <[email protected]>
Cc: Stephane Eranian <[email protected]>
Cc: Tom Zanussi <[email protected]>
LKML-Reference: <new-submission>
Signed-off-by Arnaldo Carvalho de Melo <[email protected]>
--- tools/perf/util/ui/browsers/top.c | 23 +++++++++++++++++++++++ 1 files changed, 23 insertions(+), 0 deletions(-)
tools/perf/util/ui/browsers/top.c +23 -0
@@ -70,6 +70,7 @@ static void perf_top_browser__write(struct ui_browser *browser, void *entry, intstatic void perf_top_browser__update_rb_tree (struct perf_top_browser *browser) {struct perf_top *top = browser->b.priv; +u64 top_idx = browser->b.top_idx; browser->root =RB_ROOT ; browser->b.top =NULL ;
@@ -82,7 +83,29 @@ static void perf_top_browser__update_rb_tree(struct perf_top_browser *browser)if (browser->sym_width + browser->dso_width > browser->b.width -29 ) browser->sym_width = browser->b.width - browser->dso_width -29 ; } + +/* +* Adjust the ui_browser indexes since the entries in the browser->root +* rb_tree may have changed, then seek it from start, so that we get a +* possible new top of the screen. +*/ browser->b.nr_entries = top->rb_entries; + +if (top_idx >= browser->b.nr_entries) { +if (browser->b.height >= browser->b.nr_entries) + top_idx = browser->b.nr_entries - browser->b.height; +else + top_idx =0 ; + } + +if (browser->b.index >= top_idx + browser->b.height) + browser->b.index = top_idx + browser->b.index - browser->b.top_idx; + +if (browser->b.index >= browser->b.nr_entries) + browser->b.index = browser->b.nr_entries -1 ; + + browser->b.top_idx = top_idx; + browser->b.seek (&browser->b, top_idx,SEEK_SET ); }static void perf_top_browser__annotate (struct perf_top_browser *browser)