Skip to contentSkip to conversation

Fix possible double free on error

PATCH RESEND In review Thomas Jarosch 1 participant 2 messages Jan 25, 2013 – Jan 31, 2013 perf events

lore
Share & tools
lore

Thomas Jarosch

author
#0 lore raw

PATCH RESEND 1/1 Fix possible double free on error

Can only be triggered via CROSS_COMPILE env var.
Detected by cppcheck.

Signed-off-by Thomas Jarosch <[email protected]>
---
 tools/perf/arch/common.c | 1 +
 1 file changed, 1 insertion(+)
tools/perf/arch/common.c +1 -0
index 3e975cb..aacef07 100644
@@ -155,6 +155,7 @@ static int perf_session_env__lookup_binutils_path(struct perf_session_env *env,
 		if (lookup_path(buf))
 			goto out;
 		free(buf);
+		buf = NULL;
 	}
 
 	if (!strcmp(arch, "arm"))
Signature · 1 line
1.7.11.7
author
#1 lore raw

[tip:perf/core] perf tools: Fix possible double free on error

Commit-ID:  68c465ada54c730d653fc6fdc9dc0d5270b2de00
Gitweb:     http://git.kernel.org/tip/68c465ada54c730d653fc6fdc9dc0d5270b2de00
Author:     Thomas Jarosch <[email protected]>
AuthorDate: Fri, 25 Jan 2013 10:57:08 +0100
Committer:  Arnaldo Carvalho de Melo <[email protected]>
CommitDate: Wed, 30 Jan 2013 10:37:41 -0300

perf tools: Fix possible double free on error

Can only be triggered via CROSS_COMPILE env var.

Detected by cppcheck.

Signed-off-by Thomas Jarosch <[email protected]>
Link http://lkml.kernel.org/r/36736865.AIlztKhDqN@storm open here
Signed-off-by Arnaldo Carvalho de Melo <[email protected]>
---
 tools/perf/arch/common.c | 1 +
 1 file changed, 1 insertion(+)
tools/perf/arch/common.c +1 -0
index 3e975cb..aacef07 100644
@@ -155,6 +155,7 @@ static int perf_session_env__lookup_binutils_path(struct perf_session_env *env,
 		if (lookup_path(buf))
 			goto out;
 		free(buf);
+		buf = NULL;
 	}
 
 	if (!strcmp(arch, "arm"))