Skip to contentSkip to conversation

therm_throt.c: Trival fix for a unsuitable abbreviation of thermal.

Patch-next Jin Dongming 3 participants 8 messages Aug 30, 2010 – Sep 5, 2010 x86

lore
Share & tools
lore
#0 lore raw

In unexpected_thermal_interrupt(), "LVT TMR interrupt" is used in error message.

I don't think TMR is a suitable abbreviation for thermal.
1.TMR has been used in IA32 Architectures Software Developer's
Manual, and is the abbreviation for Trigger Mode Register.
2.There is not an standard abbreviation "TMR" defined for thermal
in IA32 Architectures Software Developer's Manual.
3.Though we could understand it as Thermal Monitor Register, it is
easy to be misunderstood as a *TIMER* interrupt also.

I think this patch will fix it.

---
 arch/x86/kernel/cpu/mcheck/therm_throt.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/x86/kernel/cpu/mcheck/therm_throt.c +1 -1
index d9368ee..2f9f468 100644
@@ -349,7 +349,7 @@ static void intel_thermal_interrupt(void)
 
 static void unexpected_thermal_interrupt(void)
 {
-	printk(KERN_ERR "CPU%d: Unexpected LVT TMR interrupt!\n",
+	printk(KERN_ERR "CPU%d: Unexpected LVT Thermal Interrupt!\n",
 			smp_processor_id());
 	add_taint(TAINT_MACHINE_CHECK);
 }
Signature · 1 line
1.7.1.1
#1 lore raw
Quoted 23 lines · Jin Dongming

In unexpected_thermal_interrupt(), "LVT TMR interrupt" is used in error message.

I don't think TMR is a suitable abbreviation for thermal.
1.TMR has been used in IA32 Architectures Software Developer's
Manual, and is the abbreviation for Trigger Mode Register.
2.There is not an standard abbreviation "TMR" defined for thermal
in IA32 Architectures Software Developer's Manual.
3.Though we could understand it as Thermal Monitor Register, it is
easy to be misunderstood as a *TIMER* interrupt also.

I think this patch will fix it.

---
 arch/x86/kernel/cpu/mcheck/therm_throt.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/x86/kernel/cpu/mcheck/therm_throt.c +0 -0
index d9368ee..2f9f468 100644

arch/x86/kernel/cpu/mcheck/therm_throt.c static void intel_thermal_interrupt(void) · line 355

Quoted 8 lines
arch/x86/kernel/cpu/mcheck/therm_throt.c +1 -1
@@ -349,7 +349,7 @@ static void intel_thermal_interrupt(void)
 
 static void unexpected_thermal_interrupt(void)
 {
-	printk(KERN_ERR "CPU%d: Unexpected LVT TMR interrupt!\n",
+	printk(KERN_ERR "CPU%d: Unexpected LVT Thermal Interrupt!\n",
 			smp_processor_id());
 	add_taint(TAINT_MACHINE_CHECK);
 }

I see no good reason to upper-case the first letter of each word. This is a kernel log message, not a movie title.

Other than that, I agree with your proposal.

Signature · 6 lines
Jean Delvare

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
#2 lore raw

In unexpected_thermal_interrupt(), "LVT TMR interrupt" is used in error message.

I don't think TMR is a suitable abbreviation for thermal.
1.TMR has been used in IA32 Architectures Software Developer's
Manual, and is the abbreviation for Trigger Mode Register.
2.There is not an standard abbreviation "TMR" defined for thermal
in IA32 Architectures Software Developer's Manual.
3.Though we could understand it as Thermal Monitor Register, it is
easy to be misunderstood as a *TIMER* interrupt also.

I think this patch will fix it.

---
 arch/x86/kernel/cpu/mcheck/therm_throt.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/x86/kernel/cpu/mcheck/therm_throt.c +1 -1
index d9368ee..ba52598 100644
@@ -349,7 +349,7 @@ static void intel_thermal_interrupt(void)
 
 static void unexpected_thermal_interrupt(void)
 {
-	printk(KERN_ERR "CPU%d: Unexpected LVT TMR interrupt!\n",
+	printk(KERN_ERR "CPU%d: Unexpected LVT thermal interrupt!\n",
 			smp_processor_id());
 	add_taint(TAINT_MACHINE_CHECK);
 }
Signature · 1 line
1.7.1.1
Reviewed-by
#3 lore raw
Quoted 11 lines · Jin Dongming

In unexpected_thermal_interrupt(), "LVT TMR interrupt" is used in error message.

I don't think TMR is a suitable abbreviation for thermal.
1.TMR has been used in IA32 Architectures Software Developer's
Manual, and is the abbreviation for Trigger Mode Register.
2.There is not an standard abbreviation "TMR" defined for thermal
in IA32 Architectures Software Developer's Manual.
3.Though we could understand it as Thermal Monitor Register, it is
easy to be misunderstood as a *TIMER* interrupt also.

Quoted 3 lines

I think this patch will fix it.

Quoted 17 lines
---
 arch/x86/kernel/cpu/mcheck/therm_throt.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/x86/kernel/cpu/mcheck/therm_throt.c +1 -1
index d9368ee..ba52598 100644
@@ -349,7 +349,7 @@ static void intel_thermal_interrupt(void)
 
 static void unexpected_thermal_interrupt(void)
 {
-	printk(KERN_ERR "CPU%d: Unexpected LVT TMR interrupt!\n",
+	printk(KERN_ERR "CPU%d: Unexpected LVT thermal interrupt!\n",
 			smp_processor_id());
 	add_taint(TAINT_MACHINE_CHECK);
 }
Signature · 6 lines
Jean Delvare

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
Reviewed-by
#4 lore raw
Quoted 12 lines · Jean Delvare
Quoted 11 lines · Jin Dongming

In unexpected_thermal_interrupt(), "LVT TMR interrupt" is used in error message.

I don't think TMR is a suitable abbreviation for thermal.
1.TMR has been used in IA32 Architectures Software Developer's
Manual, and is the abbreviation for Trigger Mode Register.
2.There is not an standard abbreviation "TMR" defined for thermal
in IA32 Architectures Software Developer's Manual.
3.Though we could understand it as Thermal Monitor Register, it is
easy to be misunderstood as a *TIMER* interrupt also.

Quoted 5 lines
Quoted 3 lines

I think this patch will fix it.

Quoted 11 lines
Quoted 11 lines
---
 arch/x86/kernel/cpu/mcheck/therm_throt.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/x86/kernel/cpu/mcheck/therm_throt.c +0 -0
index d9368ee..ba52598 100644
@@ -349,7 +349,7 @@ static void intel_thermal_interrupt(void)
 
Quoted 11 lines
Quoted 7 lines
arch/x86/kernel/cpu/mcheck/therm_throt.c +1 -1
 static void unexpected_thermal_interrupt(void)
 {
-	printk(KERN_ERR "CPU%d: Unexpected LVT TMR interrupt!\n",
+	printk(KERN_ERR "CPU%d: Unexpected LVT thermal interrupt!\n",
 			smp_processor_id());
 	add_taint(TAINT_MACHINE_CHECK);
 }
Signature · 1 line
Jean Delvare

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

#5 lore raw

[tip:x86/debug] therm_throt.c: Trival printk message fix for a unsuitable abbreviation of 'thermal'

In reply to Jin Dongming
Commit-ID:  6981fe03b2055685fb6da40f54518bc6baf2b751
Gitweb:     http://git.kernel.org/tip/6981fe03b2055685fb6da40f54518bc6baf2b751
Author:     Jin Dongming <[email protected]>
AuthorDate: Tue, 31 Aug 2010 09:13:33 +0900
Committer:  Ingo Molnar <[email protected]>
CommitDate: Sun, 5 Sep 2010 14:39:15 +0200

therm_throt.c: Trival printk message fix for a unsuitable abbreviation of 'thermal'

In unexpected_thermal_interrupt(), "LVT TMR interrupt" is used in error message.

I don't think TMR is a suitable abbreviation for thermal.
1.TMR has been used in IA32 Architectures Software Developer's
Manual, and is the abbreviation for Trigger Mode Register.
2.There is not an standard abbreviation "TMR" defined for thermal
in IA32 Architectures Software Developer's Manual.
3.Though we could understand it as Thermal Monitor Register, it is
easy to be misunderstood as a *TIMER* interrupt also.

I think this patch will fix it.

Cc Brown
Cc Hidetoshi Seto <[email protected]>
Cc H. Peter Anvin <[email protected]>
Cc Jean Delvare <[email protected]>
Cc Fenghua Yu <[email protected]>

LKML-Reference: <[email protected]>

---
 arch/x86/kernel/cpu/mcheck/therm_throt.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/x86/kernel/cpu/mcheck/therm_throt.c +1 -1
index c2a8b26..1d0f743 100644
@@ -348,7 +348,7 @@ static void intel_thermal_interrupt(void)
 
 static void unexpected_thermal_interrupt(void)
 {
-	printk(KERN_ERR "CPU%d: Unexpected LVT TMR interrupt!\n",
+	printk(KERN_ERR "CPU%d: Unexpected LVT thermal interrupt!\n",
 			smp_processor_id());
 	add_taint(TAINT_MACHINE_CHECK);
 }

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Reviewed-by
#6 lore raw

Re: [tip:x86/debug] therm_throt.c: Trival printk message fix for a unsuitable abbreviation of 'thermal'

6 people and 2 mailing lists Cc'd for a one-line trivial patch??

Quoted 8 lines · tip-bot for Jin Dongming
Commit-ID:  6981fe03b2055685fb6da40f54518bc6baf2b751
Gitweb:     http://git.kernel.org/tip/6981fe03b2055685fb6da40f54518bc6baf2b751
Author:     Jin Dongming <[email protected]>
AuthorDate: Tue, 31 Aug 2010 09:13:33 +0900
Committer:  Ingo Molnar <[email protected]>
CommitDate: Sun, 5 Sep 2010 14:39:15 +0200

therm_throt.c: Trival printk message fix for a unsuitable abbreviation of 'thermal'

Typo: trivial.

Quoted 12 lines

In unexpected_thermal_interrupt(), "LVT TMR interrupt" is used in error message.

I don't think TMR is a suitable abbreviation for thermal.
1.TMR has been used in IA32 Architectures Software Developer's
Manual, and is the abbreviation for Trigger Mode Register.
2.There is not an standard abbreviation "TMR" defined for thermal
in IA32 Architectures Software Developer's Manual.
3.Though we could understand it as Thermal Monitor Register, it is
easy to be misunderstood as a *TIMER* interrupt also.

Quoted 5 lines

I think this patch will fix it.

Something's fishy here.

Quoted 2 lines

Mailing lists shouldn't be included in Cc headers.

Quoted 2 lines
Cc H. Peter Anvin <[email protected]>
Cc Jean Delvare <[email protected]>

This should read:

Quoted 20 lines

Cc: Fenghua Yu <[email protected]>
LKML-Reference: <[email protected]>

---
 arch/x86/kernel/cpu/mcheck/therm_throt.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/x86/kernel/cpu/mcheck/therm_throt.c +1 -1
index c2a8b26..1d0f743 100644
@@ -348,7 +348,7 @@ static void intel_thermal_interrupt(void)
 
 static void unexpected_thermal_interrupt(void)
 {
-	printk(KERN_ERR "CPU%d: Unexpected LVT TMR interrupt!\n",
+	printk(KERN_ERR "CPU%d: Unexpected LVT thermal interrupt!\n",
 			smp_processor_id());
 	add_taint(TAINT_MACHINE_CHECK);
 }
Signature · 6 lines
Jean Delvare

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
#7 lore raw

[tip:x86/debug] therm_throt.c: Trivial printk message fix for a unsuitable abbreviation of 'thermal'

In reply to Jin Dongming
Commit-ID:  592091c0e21655bfbdf68741dd5a920c2ac2bbe6
Gitweb:     http://git.kernel.org/tip/592091c0e21655bfbdf68741dd5a920c2ac2bbe6
Author:     Jin Dongming <[email protected]>
AuthorDate: Tue, 31 Aug 2010 09:13:33 +0900
Committer:  Ingo Molnar <[email protected]>
CommitDate: Sun, 5 Sep 2010 20:26:50 +0200

therm_throt.c: Trivial printk message fix for a unsuitable abbreviation of 'thermal'

In unexpected_thermal_interrupt(), "LVT TMR interrupt" is used in error message.

I don't think TMR is a suitable abbreviation for thermal.
1.TMR has been used in IA32 Architectures Software Developer's
Manual, and is the abbreviation for Trigger Mode Register.
2.There is not an standard abbreviation "TMR" defined for thermal
in IA32 Architectures Software Developer's Manual.
3.Though we could understand it as Thermal Monitor Register, it is
easy to be misunderstood as a *TIMER* interrupt also.

I think this patch will fix it.

LKML-Reference: <[email protected]>

---
 arch/x86/kernel/cpu/mcheck/therm_throt.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/x86/kernel/cpu/mcheck/therm_throt.c +1 -1
index c2a8b26..1d0f743 100644
@@ -348,7 +348,7 @@ static void intel_thermal_interrupt(void)
 
 static void unexpected_thermal_interrupt(void)
 {
-	printk(KERN_ERR "CPU%d: Unexpected LVT TMR interrupt!\n",
+	printk(KERN_ERR "CPU%d: Unexpected LVT thermal interrupt!\n",
 			smp_processor_id());
 	add_taint(TAINT_MACHINE_CHECK);
 }