Skip to contentSkip to conversation

kernel/sched: don't expose local functions

PATCH In review H Hartley Sweeten 1 participant 2 messages Jan 14, 2010 – Jan 17, 2010

lore
Share & tools
lore

H Hartley Sweeten

author
#0 lore raw

PATCH 1/1 kernel/sched: don't expose local functions

kernel/sched: don't expose local functions

The get_rr_interval_* functions are all class methods of struct sched_class. They are not exported so make them static.

Signed-off-by H Hartley Sweeten <[email protected]>
Cc Ingo Molnar <[email protected]>
Cc Peter Zijlstra <[email protected]>

---

kernel/sched_fair.c +1 -1
index 42ac3c9..7177860 100644
@@ -2076,7 +2076,7 @@ static void moved_group_fair(struct task_struct *p, int on_rq)
 }
 #endif
 
-unsigned int get_rr_interval_fair(struct rq *rq, struct task_struct *task)
+static unsigned int get_rr_interval_fair(struct rq *rq, struct task_struct *task)
 {
 	struct sched_entity *se = &task->se;
 	unsigned int rr_interval = 0;
kernel/sched_idletask.c +1 -1
index 5f93b57..01332bf 100644
@@ -97,7 +97,7 @@ static void prio_changed_idle(struct rq *rq, struct task_struct *p,
 		check_preempt_curr(rq, p, 0);
 }
 
-unsigned int get_rr_interval_idle(struct rq *rq, struct task_struct *task)
+static unsigned int get_rr_interval_idle(struct rq *rq, struct task_struct *task)
 {
 	return 0;
 }
kernel/sched_rt.c +1 -1
index f48328a..072b3fc 100644
@@ -1721,7 +1721,7 @@ static void set_curr_task_rt(struct rq *rq)
 	dequeue_pushable_task(rq, p);
 }
 
-unsigned int get_rr_interval_rt(struct rq *rq, struct task_struct *task)
+static unsigned int get_rr_interval_rt(struct rq *rq, struct task_struct *task)
 {
 	/*
 	 * Time slice is 0 for SCHED_FIFO tasks
author
#1 lore raw

[tip:sched/core] sched: Don't expose local functions

Commit-ID:  6d686f4564f3fc7c6e678852919e48ad331d276b
Gitweb:     http://git.kernel.org/tip/6d686f4564f3fc7c6e678852919e48ad331d276b
Author:     H Hartley Sweeten <[email protected]>
AuthorDate: Wed, 13 Jan 2010 20:21:52 -0700
Committer:  Ingo Molnar <[email protected]>
CommitDate: Sun, 17 Jan 2010 08:09:45 +0100

sched: Don't expose local functions

kernel/sched: don't expose local functions

The get_rr_interval_* functions are all class methods of struct sched_class. They are not exported so make them static.

Signed-off-by H Hartley Sweeten <[email protected]>
Cc Peter Zijlstra <[email protected]>

LKML-Reference: <[email protected]>

Signed-off-by Ingo Molnar <[email protected]>
---
 kernel/sched_fair.c     |    2 +-
 kernel/sched_idletask.c |    2 +-
 kernel/sched_rt.c       |    2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)
kernel/sched_fair.c +1 -1
index 42ac3c9..7177860 100644
@@ -2076,7 +2076,7 @@ static void moved_group_fair(struct task_struct *p, int on_rq)
 }
 #endif
 
-unsigned int get_rr_interval_fair(struct rq *rq, struct task_struct *task)
+static unsigned int get_rr_interval_fair(struct rq *rq, struct task_struct *task)
 {
 	struct sched_entity *se = &task->se;
 	unsigned int rr_interval = 0;
kernel/sched_idletask.c +1 -1
index 5f93b57..01332bf 100644
@@ -97,7 +97,7 @@ static void prio_changed_idle(struct rq *rq, struct task_struct *p,
 		check_preempt_curr(rq, p, 0);
 }
 
-unsigned int get_rr_interval_idle(struct rq *rq, struct task_struct *task)
+static unsigned int get_rr_interval_idle(struct rq *rq, struct task_struct *task)
 {
 	return 0;
 }
kernel/sched_rt.c +1 -1
index f48328a..072b3fc 100644
@@ -1721,7 +1721,7 @@ static void set_curr_task_rt(struct rq *rq)
 	dequeue_pushable_task(rq, p);
 }
 
-unsigned int get_rr_interval_rt(struct rq *rq, struct task_struct *task)
+static unsigned int get_rr_interval_rt(struct rq *rq, struct task_struct *task)
 {
 	/*
 	 * Time slice is 0 for SCHED_FIFO tasks