Skip to contentSkip to conversation

perf db-export: No need to pass thread twice to db_export__sample

tip:perf/core tip-bot for Arnaldo Carvalho de Melo 1 participant 1 message Apr 3, 2015 perf events

lore
Share & tools
lore
#0 lore raw
Commit-ID:  7327259d7ea96d04d02e7dbe51ee9201319dc204
Gitweb:     http://git.kernel.org/tip/7327259d7ea96d04d02e7dbe51ee9201319dc204
Author:     Arnaldo Carvalho de Melo <[email protected]>
AuthorDate: Thu, 2 Apr 2015 11:08:30 -0300
Committer:  Arnaldo Carvalho de Melo <[email protected]>
CommitDate: Thu, 2 Apr 2015 13:18:42 -0300

perf db-export: No need to pass thread twice to db_export__sample

As it is available via another parameter, address_location->thread.

Cc Borislav Petkov <[email protected]>
Cc David Ahern <[email protected]>
Cc Don Zickus <[email protected]>
Cc Frederic Weisbecker <[email protected]>
Cc Jiri Olsa <[email protected]>
Cc Namhyung Kim <[email protected]>
Cc Stephane Eranian <[email protected]>
Link lkml.kernel.org/r/[email protected]
---
 tools/perf/util/db-export.c                            | 3 ++-
 tools/perf/util/db-export.h                            | 2 +-
 tools/perf/util/scripting-engines/trace-event-python.c | 3 +--
 3 files changed, 4 insertions(+), 4 deletions(-)
tools/perf/util/db-export.c +2 -1
index c81dae3..5499887 100644
@@ -282,8 +282,9 @@ int db_export__branch_type(struct db_export *dbe, u32 branch_type,
 
 int db_export__sample(struct db_export *dbe, union perf_event *event,
 		      struct perf_sample *sample, struct perf_evsel *evsel,
-		      struct thread *thread, struct addr_location *al)
+		      struct addr_location *al)
 {
+	struct thread* thread = al->thread;
 	struct export_sample es = {
 		.event = event,
 		.sample = sample,
tools/perf/util/db-export.h +1 -1
index adbd22d..b9faa13 100644
@@ -97,7 +97,7 @@ int db_export__branch_type(struct db_export *dbe, u32 branch_type,
 			   const char *name);
 int db_export__sample(struct db_export *dbe, union perf_event *event,
 		      struct perf_sample *sample, struct perf_evsel *evsel,
-		      struct thread *thread, struct addr_location *al);
+		      struct addr_location *al);
 
 int db_export__branch_types(struct db_export *dbe);
 
tools/perf/util/scripting-engines/trace-event-python.c +1 -2
index de8df1d..1d3cc1b 100644
@@ -852,8 +852,7 @@ static void python_process_event(union perf_event *event,
 	/* Reserve for future process_hw/sw/raw APIs */
 	default:
 		if (tables->db_export_mode)
-			db_export__sample(&tables->dbe, event, sample, evsel,
-					  al->thread, al);
+			db_export__sample(&tables->dbe, event, sample, evsel, al);
 		else
 			python_process_general_event(sample, evsel, al);
 	}