Skip to contentSkip to conversation

perf scripts python: export-to-sqlite.py: Fix use of parent_id in calls_view

PATCH Applied Adrian Hunter 3 participants 4 messages Apr 9, 2019 – Apr 16, 2019 perf events

lore
Share & tools
lore

Adrian Hunter

author reviewer
#0 lore raw

PATCH 1/1 perf scripts python: export-to-sqlite.py: Fix use of parent_id in calls_view

Fix following error using calls_view:
Query failed: ambiguous column name: parent_id Unable to execute statement

Fixes 8ce9a7251d11 ("perf scripts python: export-to-sqlite.py: Export calls parent_id")
---
 tools/perf/scripts/python/export-to-sqlite.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/perf/scripts/python/export-to-sqlite.py +1 -1
index 3b71902a5a21..bf271fbc3a88 100644
@@ -331,7 +331,7 @@ if perf_db_export_calls:
 			'return_id,'
 			'CASE WHEN flags=0 THEN \'\' WHEN flags=1 THEN \'no call\' WHEN flags=2 THEN \'no return\' WHEN flags=3 THEN \'no call/return\' WHEN flags=6 THEN \'jump\' ELSE flags END AS flags,'
 			'parent_call_path_id,'
-			'parent_id'
+			'calls.parent_id'
 		' FROM calls INNER JOIN call_paths ON call_paths.id = call_path_id')
 
 do_query(query, 'CREATE VIEW samples_view AS '
Signature · 1 line
2.17.1
#1 lore raw

Em Tue, Apr 09, 2019 at 09:25:57AM +0300, Adrian Hunter escreveu:

Quoted 4 lines

Fix following error using calls_view:
Query failed: ambiguous column name: parent_id Unable to execute statement

Applied, and thanks for the Fixes tag, appreciated,

- Arnaldo

Quoted 20 lines
Fixes 8ce9a7251d11 ("perf scripts python: export-to-sqlite.py: Export calls parent_id")
---
 tools/perf/scripts/python/export-to-sqlite.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/perf/scripts/python/export-to-sqlite.py +1 -1
index 3b71902a5a21..bf271fbc3a88 100644
@@ -331,7 +331,7 @@ if perf_db_export_calls:
 			'return_id,'
 			'CASE WHEN flags=0 THEN \'\' WHEN flags=1 THEN \'no call\' WHEN flags=2 THEN \'no return\' WHEN flags=3 THEN \'no call/return\' WHEN flags=6 THEN \'jump\' ELSE flags END AS flags,'
 			'parent_call_path_id,'
-			'parent_id'
+			'calls.parent_id'
 		' FROM calls INNER JOIN call_paths ON call_paths.id = call_path_id')
 
 do_query(query, 'CREATE VIEW samples_view AS '
Signature · 1 line
2.17.1
Signature · 1 line
- Arnaldo
#2 lore raw
In reply to Adrian Hunter
perf scripts python: export-to-sqlite.py: Fix use of parent_id in calls_view
Commit-ID:  961df45e5de662e65fc6bc415fecc8caa8a3045c
Gitweb:     https://git.kernel.org/tip/961df45e5de662e65fc6bc415fecc8caa8a3045c
Author:     Adrian Hunter <[email protected]>
AuthorDate: Tue, 9 Apr 2019 09:25:57 +0300
Committer:  Arnaldo Carvalho de Melo <[email protected]>
CommitDate: Tue, 9 Apr 2019 10:15:00 -0300

perf scripts python: export-to-sqlite.py: Fix use of parent_id in calls_view

Fix following error using calls_view:

Query failed: ambiguous column name: parent_id Unable to execute statement

Cc Jiri Olsa <[email protected]>
Fixes 8ce9a7251d11 ("perf scripts python: export-to-sqlite.py: Export calls parent_id")
---
 tools/perf/scripts/python/export-to-sqlite.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/perf/scripts/python/export-to-sqlite.py +1 -1
index 3b71902a5a21..bf271fbc3a88 100644
@@ -331,7 +331,7 @@ if perf_db_export_calls:
 			'return_id,'
 			'CASE WHEN flags=0 THEN \'\' WHEN flags=1 THEN \'no call\' WHEN flags=2 THEN \'no return\' WHEN flags=3 THEN \'no call/return\' WHEN flags=6 THEN \'jump\' ELSE flags END AS flags,'
 			'parent_call_path_id,'
-			'parent_id'
+			'calls.parent_id'
 		' FROM calls INNER JOIN call_paths ON call_paths.id = call_path_id')
 
 do_query(query, 'CREATE VIEW samples_view AS '
#3 lore raw
In reply to Adrian Hunter
perf scripts python: export-to-sqlite.py: Fix use of parent_id in calls_view
Commit-ID:  6e4b1cac30d297718218dc268199ed20df074b98
Gitweb:     https://git.kernel.org/tip/6e4b1cac30d297718218dc268199ed20df074b98
Author:     Adrian Hunter <[email protected]>
AuthorDate: Tue, 9 Apr 2019 09:25:57 +0300
Committer:  Arnaldo Carvalho de Melo <[email protected]>
CommitDate: Tue, 16 Apr 2019 11:27:05 -0300

perf scripts python: export-to-sqlite.py: Fix use of parent_id in calls_view

Fix following error using calls_view:

Query failed: ambiguous column name: parent_id Unable to execute statement

Cc Jiri Olsa <[email protected]>
Fixes 8ce9a7251d11 ("perf scripts python: export-to-sqlite.py: Export calls parent_id")
---
 tools/perf/scripts/python/export-to-sqlite.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/perf/scripts/python/export-to-sqlite.py +1 -1
index 3b71902a5a21..bf271fbc3a88 100644
@@ -331,7 +331,7 @@ if perf_db_export_calls:
 			'return_id,'
 			'CASE WHEN flags=0 THEN \'\' WHEN flags=1 THEN \'no call\' WHEN flags=2 THEN \'no return\' WHEN flags=3 THEN \'no call/return\' WHEN flags=6 THEN \'jump\' ELSE flags END AS flags,'
 			'parent_call_path_id,'
-			'parent_id'
+			'calls.parent_id'
 		' FROM calls INNER JOIN call_paths ON call_paths.id = call_path_id')
 
 do_query(query, 'CREATE VIEW samples_view AS '