Skip to contentSkip to conversation

sched: Disable SD_PREFER_LOCAL at node level

tip:sched/urgent tip-bot for Mike Galbraith 1 participant 1 message Nov 2, 2009 x86

lore
Share & tools
lore
#0 lore raw
Commit-ID:  753c72119743e8a12f5e9d34312988c810458917
Gitweb:     http://git.kernel.org/tip/753c72119743e8a12f5e9d34312988c810458917
Author:     Mike Galbraith <[email protected]>
AuthorDate: Mon, 2 Nov 2009 20:36:51 +0100
Committer:  Ingo Molnar <[email protected]>
CommitDate: Mon, 2 Nov 2009 20:43:07 +0100

sched: Disable SD_PREFER_LOCAL at node level

Yanmin Zhang reported that SD_PREFER_LOCAL induces an order of magnitude increase in select_task_rq_fair() overhead while running heavy wakeup benchmarks (tbench and vmark).

Since SD_BALANCE_WAKE is off at node level, turn SD_PREFER_LOCAL off as well pending further investigation.

LKML-Reference: <new-submission>

---
 arch/x86/include/asm/topology.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/x86/include/asm/topology.h +1 -1
index d823c24..40e37b1 100644
@@ -143,7 +143,7 @@ extern unsigned long node_remap_size[];
 				| 1*SD_BALANCE_FORK			\
 				| 0*SD_BALANCE_WAKE			\
 				| 1*SD_WAKE_AFFINE			\
-				| 1*SD_PREFER_LOCAL			\
+				| 0*SD_PREFER_LOCAL			\
 				| 0*SD_SHARE_CPUPOWER			\
 				| 0*SD_POWERSAVINGS_BALANCE		\
 				| 0*SD_SHARE_PKG_RESOURCES		\