kernel: trace: ftrace: strncpy, using strlcpy instead of strncpy
PATCH 1/1 kernel: trace: ftrace: strncpy, using strlcpy instead of strncpy
for NUL terminated string, need always set '\0' at the end.
--- kernel/trace/ftrace.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
kernel/trace/ftrace.c +2 -2
@@ -3492,14 +3492,14 @@ static char ftrace_filter_buf[FTRACE_FILTER_SIZE] __initdata;static int __init set_ftrace_notrace (char *str) { -strncpy (ftrace_notrace_buf, str,FTRACE_FILTER_SIZE ); +strlcpy (ftrace_notrace_buf, str,FTRACE_FILTER_SIZE );return 1 ; }__setup ("ftrace_notrace=" , set_ftrace_notrace);static int __init set_ftrace_filter (char *str) { -strncpy (ftrace_filter_buf, str,FTRACE_FILTER_SIZE ); +strlcpy (ftrace_filter_buf, str,FTRACE_FILTER_SIZE );return 1 ; }__setup ("ftrace_filter=" , set_ftrace_filter);
Signature · 1 line
1.7.7.6
tip-bot for Chen Gang
merge bot[tip:perf/urgent] ftrace: Fix strncpy() use, use strlcpy() instead of strncpy()
ftrace: Fix strncpy() use, use strlcpy() instead of strncpy()
Commit-ID: 75761cc15877c155b3849b4e0e0cb3f897faf471 Gitweb: http://git.kernel.org/tip/75761cc15877c155b3849b4e0e0cb3f897faf471 Author: Chen Gang <[email protected]> AuthorDate: Mon, 8 Apr 2013 12:12:39 +0800 Committer: Ingo Molnar <[email protected]> CommitDate: Mon, 8 Apr 2013 13:26:56 +0200
ftrace: Fix strncpy() use, use strlcpy() instead of strncpy()
For NUL terminated string we always need to set '\0' at the end.
--- kernel/trace/ftrace.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
kernel/trace/ftrace.c +2 -2
@@ -3441,14 +3441,14 @@ static char ftrace_filter_buf[FTRACE_FILTER_SIZE] __initdata;static int __init set_ftrace_notrace (char *str) { -strncpy (ftrace_notrace_buf, str,FTRACE_FILTER_SIZE ); +strlcpy (ftrace_notrace_buf, str,FTRACE_FILTER_SIZE );return 1 ; }__setup ("ftrace_notrace=" , set_ftrace_notrace);static int __init set_ftrace_filter (char *str) { -strncpy (ftrace_filter_buf, str,FTRACE_FILTER_SIZE ); +strlcpy (ftrace_filter_buf, str,FTRACE_FILTER_SIZE );return 1 ; }__setup ("ftrace_filter=" , set_ftrace_filter);
Re: [tip:perf/urgent] ftrace: Fix strncpy() use, use strlcpy() instead of strncpy()
Quoted 9 lines · tip-bot for Chen Gang
Commit-ID: 75761cc15877c155b3849b4e0e0cb3f897faf471 Gitweb: http://git.kernel.org/tip/75761cc15877c155b3849b4e0e0cb3f897faf471 Author: Chen Gang <[email protected]> AuthorDate: Mon, 8 Apr 2013 12:12:39 +0800 Committer: Ingo Molnar <[email protected]> CommitDate: Mon, 8 Apr 2013 13:26:56 +0200ftrace: Fix
strncpy()use, usestrlcpy()instead ofstrncpy()
Quoted 8 lines
For NUL terminated string we always need to set '\0' at the end.
Signed-off-by Chen Gang <[email protected]>Cc Frederic Weisbecker <[email protected]>Signed-off-by Ingo Molnar <[email protected]>---
thank you very much for applying the 3 related patches.
Signature · 3 lines
Chen Gang Asianux Corporation
Steven Rostedt
maintainerI'll queue this up for my 3.10 queue. I'm going to merge this patch with the previous patch you sent that updates trace.c
Thanks,
-- Steve
Quoted 28 lines · Chen Gang
for NUL terminated string, need always set '\0' at the end.
Signed-off-by Chen Gang <[email protected]>--- kernel/trace/ftrace.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)kernel/trace/ftrace.c +2
-2@@ -3492,14 +3492,14 @@ static char ftrace_filter_buf[FTRACE_FILTER_SIZE] __initdata;static int __init set_ftrace_notrace (char *str) { -strncpy (ftrace_notrace_buf, str,FTRACE_FILTER_SIZE ); +strlcpy (ftrace_notrace_buf, str,FTRACE_FILTER_SIZE );return 1 ; }__setup ("ftrace_notrace=" , set_ftrace_notrace);static int __init set_ftrace_filter (char *str) { -strncpy (ftrace_filter_buf, str,FTRACE_FILTER_SIZE ); +strlcpy (ftrace_filter_buf, str,FTRACE_FILTER_SIZE );return 1 ; }__setup ("ftrace_filter=" , set_ftrace_filter);
Quoted 6 lines · Steven Rostedt
I'll queue this up for my 3.10 queue. I'm going to merge this patch with the previous patch you sent that updates
trace.cThanks,
-- Steve
thanks too.
Signature · 3 lines
Chen Gang Flying Transformer