Skip to contentSkip to conversation

x86: mm/init.c declare check_efer() before it get used

PATCH In review Jaswinder Singh Rajput 1 participant 2 messages Jul 1, 2009

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 x86: mm/init.c declare check_efer() before it get used

This sparse warning:

arch/x86/mm/init.c:83:16: warning: symbol 'check_efer' was not declared. Should it be static?

triggers because check_efer() is not decalared before using it. asm/proto.h includes the declaration of check_efer(),
so including asm/proto.h to fix that - this also address the sparse warning.

---
 arch/x86/mm/init.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
arch/x86/mm/init.c +1 -0
index 47ce9a2..0607119 100644
@@ -12,6 +12,7 @@
 #include <asm/system.h>
 #include <asm/tlbflush.h>
 #include <asm/tlb.h>
+#include <asm/proto.h>
 
 DEFINE_PER_CPU(struct mmu_gather, mmu_gathers);
 
Signature · 1 line
1.6.0.6
#1 lore raw

[tip:x86/urgent] x86: Declare check_efer() before it gets used

Commit-ID:  76c06927f2a78143763dcff9b4c362d15eb29cc2
Gitweb:     http://git.kernel.org/tip/76c06927f2a78143763dcff9b4c362d15eb29cc2
Author:     Jaswinder Singh Rajput <[email protected]>
AuthorDate: Wed, 1 Jul 2009 19:54:23 +0530
Committer:  Ingo Molnar <[email protected]>
CommitDate: Wed, 1 Jul 2009 16:52:54 +0200

x86: Declare check_efer() before it gets used

This sparse warning:

arch/x86/mm/init.c:83:16: warning: symbol 'check_efer' was not declared. Should it be static?

triggers because check_efer() is not decalared before using it. asm/proto.h includes the declaration of check_efer(), so including asm/proto.h to fix that - this also addresses the sparse warning.

LKML-Reference: <[email protected]>

---
 arch/x86/mm/init.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
arch/x86/mm/init.c +1 -0
index 47ce9a2..0607119 100644
@@ -12,6 +12,7 @@
 #include <asm/system.h>
 #include <asm/tlbflush.h>
 #include <asm/tlb.h>
+#include <asm/proto.h>
 
 DEFINE_PER_CPU(struct mmu_gather, mmu_gathers);