Skip to contentSkip to conversation

Fix segfault in perf probe

PATCH In review Ananth N Mavinakayanahalli 3 participants 3 messages Mar 12, 2013 – Mar 18, 2013 perf events

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Fix segfault in perf probe

From: Ananth N Mavinakayanahalli <[email protected]>

Fix segfault in perf probe due to a bug introduced by commit d8639f068 (perf tools: Stop using 'self' in strlist).

---

tools/perf/util/strlist.c +1 -1
Index: linus/tools/perf/util/strlist.c
===================================================================
@@ -143,7 +143,7 @@ struct strlist *strlist__new(bool dupstr
 		slist->rblist.node_delete = strlist__node_delete;
 
 		slist->dupstr	 = dupstr;
-		if (slist && strlist__parse_list(slist, list) != 0)
+		if (list && strlist__parse_list(slist, list) != 0)
 			goto out_error;
 	}
 
Acked-by on v1 1/1
#1 lore raw
Quoted 7 lines · Ananth N Mavinakayanahalli

From: Ananth N Mavinakayanahalli <[email protected]>

Fix segfault in perf probe due to a bug introduced by commit d8639f068 (perf tools: Stop using 'self' in strlist).

Quoted 15 lines

---
Index: linus/tools/perf/util/strlist.c
===================================================================

tools/perf/util/strlist.c +1 -1
@@ -143,7 +143,7 @@ struct strlist *strlist__new(bool dupstr
 		slist->rblist.node_delete = strlist__node_delete;
 
 		slist->dupstr	 = dupstr;
-		if (slist && strlist__parse_list(slist, list) != 0)
+		if (list && strlist__parse_list(slist, list) != 0)
 			goto out_error;
 	}
 
Signature · 2 lines
Thanks and Regards
Srikar Dronamraju
#2 lore raw

[tip:perf/urgent] perf probe: Fix segfault

In reply to Ananth N Mavinakayanahalli
perf probe: Fix segfault
Commit-ID:  79146a69c8bc3f28e51c5267633abc6babf47a31
Gitweb:     http://git.kernel.org/tip/79146a69c8bc3f28e51c5267633abc6babf47a31
Author:     Ananth N Mavinakayanahalli <[email protected]>
AuthorDate: Tue, 12 Mar 2013 14:32:17 +0530
Committer:  Arnaldo Carvalho de Melo <[email protected]>
CommitDate: Wed, 13 Mar 2013 17:00:33 -0300

perf probe: Fix segfault

Fix segfault in perf probe due to a bug introduced by commit d8639f068 (perf tools: Stop using 'self' in strlist).

---
 tools/perf/util/strlist.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/perf/util/strlist.c +1 -1
index 55433aa..eabdce0 100644
@@ -143,7 +143,7 @@ struct strlist *strlist__new(bool dupstr, const char *list)
 		slist->rblist.node_delete = strlist__node_delete;
 
 		slist->dupstr	 = dupstr;
-		if (slist && strlist__parse_list(slist, list) != 0)
+		if (list && strlist__parse_list(slist, list) != 0)
 			goto out_error;
 	}