x86, fix defined for VECTOR_UNDEFINED and VECTOR_RETRIGGERED
PATCH 1/1 x86, fix defined for VECTOR_UNDEFINED and VECTOR_RETRIGGERED
Resending ... want to make sure this wasn't dropped for some reason.
Sent previously here: http://marc.info/?l=linux-kernel&m=139405208523968&w=2
P.
---8<---
During another patch review, David Rientjes noted that VECTOR_UNDEFINED and VECTOR_RETRIGGERED should be defined with ()s so that they are not erroneously used in an arithmetic operation.
Signed-off-by Prarit Bhargava <[email protected]>
Cc Thomas Gleixner <[email protected]>
Cc Ingo Molnar <[email protected]>
Cc "H. Peter Anvin" <[email protected]>
Cc Seiji Aguchi <[email protected]>
Cc Yang Zhang <[email protected]>
Cc Andi Kleen <[email protected]>
Cc David Rientjes <[email protected]>
--- arch/x86/include/asm/hw_irq.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
arch/x86/include/asm/hw_irq.h +2 -2
@@ -191,8 +191,8 @@ extern void (*__initconst interrupt[NR_VECTORS-FIRST_EXTERNAL_VECTOR])(void);#define trace_interrupt interrupt#endif -#define VECTOR_UNDEFINED -1 -#define VECTOR_RETRIGGERED -2 +#define VECTOR_UNDEFINED (-1) +#define VECTOR_RETRIGGERED (-2)typedef int vector_irq_t [NR_VECTORS ];DECLARE_PER_CPU (vector_irq_t, vector_irq);
Signature · 1 line
1.7.9.3
tip-bot for Prarit Bhargava
merge bot[tip:x86/apic] x86/irq: Clean up VECTOR_UNDEFINED and VECTOR_RETRIGGERED definition
x86/irq: Clean up VECTOR_UNDEFINED and VECTOR_RETRIGGERED definition
Commit-ID: 79a51b25badae79d2da6f7b54530adf56697f669 Gitweb: http://git.kernel.org/tip/79a51b25badae79d2da6f7b54530adf56697f669 Author: Prarit Bhargava <[email protected]> AuthorDate: Wed, 2 Apr 2014 08:13:47 -0400 Committer: Ingo Molnar <[email protected]> CommitDate: Mon, 14 Apr 2014 13:42:05 +0200
x86/irq: Clean up VECTOR_UNDEFINED and VECTOR_RETRIGGERED definition
During another patch review, David Rientjes noted that VECTOR_UNDEFINED and VECTOR_RETRIGGERED should be defined with ()s so that they are not erroneously used in an arithmetic operation.
Suggested-by David Rientjes <[email protected]>
Signed-off-by Prarit Bhargava <[email protected]>
Cc Seiji Aguchi <[email protected]>
Cc Yang Zhang <[email protected]>
Signed-off-by Ingo Molnar <[email protected]>
--- arch/x86/include/asm/hw_irq.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
arch/x86/include/asm/hw_irq.h +2 -2
@@ -190,8 +190,8 @@ extern void (*__initconst interrupt[NR_VECTORS-FIRST_EXTERNAL_VECTOR])(void);#define trace_interrupt interrupt#endif -#define VECTOR_UNDEFINED -1 -#define VECTOR_RETRIGGERED -2 +#define VECTOR_UNDEFINED (-1) +#define VECTOR_RETRIGGERED (-2)typedef int vector_irq_t [NR_VECTORS ];DECLARE_PER_CPU (vector_irq_t, vector_irq);