Skip to contentSkip to conversation

lockdep: Print more info when MAX_LOCK_DEPTH is exceeded.

PATCH In review [email protected] 2 participants 3 messages Feb 6, 2013 – Feb 22, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 lockdep: Print more info when MAX_LOCK_DEPTH is exceeded.

From: Ben Greear <[email protected]>

This helps debug cases where a lock is acquired over and over without being released.

---
 kernel/lockdep.c |    6 +++++-
 1 files changed, 5 insertions(+), 1 deletions(-)
kernel/lockdep.c +5 -1
index 7981e5b..7e76b69 100644
@@ -3189,8 +3189,12 @@ static int __lock_acquire(struct lockdep_map *lock, unsigned int subclass,
 		return 0;
 #endif
 	if (unlikely(curr->lockdep_depth >= MAX_LOCK_DEPTH)) {
+		debug_show_all_locks();
+		lockdep_print_held_locks(current);
+
 		debug_locks_off();
-		printk("BUG: MAX_LOCK_DEPTH too low!\n");
+		printk("BUG: MAX_LOCK_DEPTH too low, depth: %i  max: %lu!\n",
+		       curr->lockdep_depth, MAX_LOCK_DEPTH);
 		printk("turning off the locking correctness validator.\n");
 		dump_stack();
 		return 0;
Signature · 1 line
1.7.3.4
#1 lore raw

[tip:core/locking] lockdep: Print more info when MAX_LOCK_DEPTH is exceeded

Commit-ID:  7a508076d4efdfd4fcb6fbd50a32d2c1a6e98791
Gitweb:     http://git.kernel.org/tip/7a508076d4efdfd4fcb6fbd50a32d2c1a6e98791
Author:     Ben Greear <[email protected]>
AuthorDate: Wed, 6 Feb 2013 10:56:19 -0800
Committer:  Ingo Molnar <[email protected]>
CommitDate: Thu, 7 Feb 2013 12:17:43 +0100

lockdep: Print more info when MAX_LOCK_DEPTH is exceeded

This helps debug cases where a lock is acquired over and over without being released.

---
 kernel/lockdep.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)
kernel/lockdep.c +6 -1
index c783e80..1966746 100644
@@ -3192,9 +3192,14 @@ static int __lock_acquire(struct lockdep_map *lock, unsigned int subclass,
 #endif
 	if (unlikely(curr->lockdep_depth >= MAX_LOCK_DEPTH)) {
 		debug_locks_off();
-		printk("BUG: MAX_LOCK_DEPTH too low!\n");
+		printk("BUG: MAX_LOCK_DEPTH too low, depth: %i  max: %lu!\n",
+		       curr->lockdep_depth, MAX_LOCK_DEPTH);
 		printk("turning off the locking correctness validator.\n");
+
+		lockdep_print_held_locks(current);
+		debug_show_all_locks();
 		dump_stack();
+
 		return 0;
 	}
 
#2 lore raw

[tip:core/locking] lockdep: Print more info when MAX_LOCK_DEPTH is exceeded

In reply to [email protected]
lockdep: Print more info when MAX_LOCK_DEPTH is exceeded
Commit-ID:  c0540606837af79b2ae101e5e7b2206e3844d150
Gitweb:     http://git.kernel.org/tip/c0540606837af79b2ae101e5e7b2206e3844d150
Author:     Ben Greear <[email protected]>
AuthorDate: Wed, 6 Feb 2013 10:56:19 -0800
Committer:  Ingo Molnar <[email protected]>
CommitDate: Tue, 19 Feb 2013 08:42:44 +0100

lockdep: Print more info when MAX_LOCK_DEPTH is exceeded

This helps debug cases where a lock is acquired over and over without being released.

---
 kernel/lockdep.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)
kernel/lockdep.c +6 -1
index 5cf12e7..8a0efac 100644
@@ -3190,9 +3190,14 @@ static int __lock_acquire(struct lockdep_map *lock, unsigned int subclass,
 #endif
 	if (unlikely(curr->lockdep_depth >= MAX_LOCK_DEPTH)) {
 		debug_locks_off();
-		printk("BUG: MAX_LOCK_DEPTH too low!\n");
+		printk("BUG: MAX_LOCK_DEPTH too low, depth: %i  max: %lu!\n",
+		       curr->lockdep_depth, MAX_LOCK_DEPTH);
 		printk("turning off the locking correctness validator.\n");
+
+		lockdep_print_held_locks(current);
+		debug_show_all_locks();
 		dump_stack();
+
 		return 0;
 	}