perf stat: Disable DIR_FORMAT feature for record
Jiri Olsa
reviewerPATCH 1/1 perf stat: Disable DIR_FORMAT feature for record
Arnaldo reported assertion in perf stat record:
assertion failed at util/header.c:875
There's no support for this in perf state record
command, disabling the feature.
--- tools/perf/builtin-stat.c | 1 + 1 file changed, 1 insertion(+)
tools/perf/builtin-stat.c +1 -0
@@ -1322,6 +1322,7 @@ static void init_features(struct perf_session *session)for (feat =HEADER_FIRST_FEATURE ; feat <HEADER_LAST_FEATURE ; feat++)perf_header__set_feat (&session->header, feat); +perf_header__clear_feat (&session->header,HEADER_DIR_FORMAT );perf_header__clear_feat (&session->header,HEADER_BUILD_ID );perf_header__clear_feat (&session->header,HEADER_TRACING_DATA );perf_header__clear_feat (&session->header,HEADER_BRANCH_STACK );
Signature · 1 line
2.17.2
Arnaldo Carvalho de Melo
AppliedEm Tue, Apr 09, 2019 at 12:01:56PM +0200, Jiri Olsa escreveu:
Quoted 3 lines
Arnaldo reported assertion in perf stat record:
assertion failed at
util/header.c:875
Thanks, applied and added:
- Arnaldo
Quoted 25 lines
There's no support for this in perf state record
command, disabling the feature.Reported-by Arnaldo Carvalho de Melo <[email protected]>Signed-off-by Jiri Olsa <[email protected]>--- tools/perf/builtin-stat.c | 1 + 1 file changed, 1 insertion(+)tools/perf/builtin-stat.c +1
-0@@ -1322,6 +1322,7 @@ static void init_features(struct perf_session *session)for (feat =HEADER_FIRST_FEATURE ; feat <HEADER_LAST_FEATURE ; feat++)perf_header__set_feat (&session->header, feat); +perf_header__clear_feat (&session->header,HEADER_DIR_FORMAT );perf_header__clear_feat (&session->header,HEADER_BUILD_ID );perf_header__clear_feat (&session->header,HEADER_TRACING_DATA );perf_header__clear_feat (&session->header,HEADER_BRANCH_STACK );Signature · 1 line
2.17.2
Signature · 1 line
- Arnaldo
tip-bot for Jiri Olsa
merge bot[tip:perf/urgent] perf stat: Disable DIR_FORMAT feature for 'perf stat record'
In reply to Jiri Olsaperf stat: Disable DIR_FORMAT feature for 'perf stat record'
Commit-ID: d2d0aef9277a7e9e110545552b48b8f523ac62a4 Gitweb: https://git.kernel.org/tip/d2d0aef9277a7e9e110545552b48b8f523ac62a4 Author: Jiri Olsa <[email protected]> AuthorDate: Tue, 9 Apr 2019 12:01:56 +0200 Committer: Arnaldo Carvalho de Melo <[email protected]> CommitDate: Tue, 9 Apr 2019 10:17:34 -0300
perf stat: Disable DIR_FORMAT feature for 'perf stat record'
Arnaldo reported assertion in perf stat record:
assertion failed at util/header.c:875
There's no support for this in the 'perf state record' command, disable the feature for that case.
--- tools/perf/builtin-stat.c | 1 + 1 file changed, 1 insertion(+)
tools/perf/builtin-stat.c +1 -0
@@ -1308,6 +1308,7 @@ static void init_features(struct perf_session *session)for (feat =HEADER_FIRST_FEATURE ; feat <HEADER_LAST_FEATURE ; feat++)perf_header__set_feat (&session->header, feat); +perf_header__clear_feat (&session->header,HEADER_DIR_FORMAT );perf_header__clear_feat (&session->header,HEADER_BUILD_ID );perf_header__clear_feat (&session->header,HEADER_TRACING_DATA );perf_header__clear_feat (&session->header,HEADER_BRANCH_STACK );
tip-bot for Jiri Olsa
merge bot[tip:perf/urgent] perf stat: Disable DIR_FORMAT feature for 'perf stat record'
In reply to Jiri Olsaperf stat: Disable DIR_FORMAT feature for 'perf stat record'
Commit-ID: 8002a63f9ace7e9c958408f77f0a4dd4a8414511 Gitweb: https://git.kernel.org/tip/8002a63f9ace7e9c958408f77f0a4dd4a8414511 Author: Jiri Olsa <[email protected]> AuthorDate: Tue, 9 Apr 2019 12:01:56 +0200 Committer: Arnaldo Carvalho de Melo <[email protected]> CommitDate: Tue, 16 Apr 2019 11:27:18 -0300
perf stat: Disable DIR_FORMAT feature for 'perf stat record'
Arnaldo reported assertion in perf stat record:
assertion failed at util/header.c:875
There's no support for this in the 'perf state record' command, disable the feature for that case.
--- tools/perf/builtin-stat.c | 1 + 1 file changed, 1 insertion(+)
tools/perf/builtin-stat.c +1 -0
@@ -1308,6 +1308,7 @@ static void init_features(struct perf_session *session)for (feat =HEADER_FIRST_FEATURE ; feat <HEADER_LAST_FEATURE ; feat++)perf_header__set_feat (&session->header, feat); +perf_header__clear_feat (&session->header,HEADER_DIR_FORMAT );perf_header__clear_feat (&session->header,HEADER_BUILD_ID );perf_header__clear_feat (&session->header,HEADER_TRACING_DATA );perf_header__clear_feat (&session->header,HEADER_BRANCH_STACK );