Skip to contentSkip to conversation

linux-next: tip tree build warning

PATCH In review Stephen Rothwell 2 participants 4 messages Nov 25, 2009 – Nov 26, 2009 Linux-next tree

lore
Share & tools
lore
#0 lore raw

Hi all,

Today's linux-next build (powerpc ppc64_defconfig) produced this warning:

kernel/perf_event.c:4306: warning: 'bp_perf_event_destroy' defined but not used

Introduced by commit 24f1e32c60c45c89a997c73395b69c8af6f0a84e ("hw-breakpoints: Rewrite the hw-breakpoints layer on top of perf events").

Signature · 3 lines
Cheers,
Stephen Rothwell                    [email protected]
http://www.canb.auug.org.au/~sfr/
#1 lore raw
Quoted 9 lines · Stephen Rothwell

Hi all,

Today's linux-next build (powerpc ppc64_defconfig) produced this warning:

kernel/perf_event.c:4306: warning: 'bp_perf_event_destroy' defined but not used

Introduced by commit 24f1e32c60c45c89a997c73395b69c8af6f0a84e ("hw-breakpoints: Rewrite the hw-breakpoints layer on top of perf events").

Oh I see, it's not used in the off-case. I'll fix that soon. Thanks for the report!

#2 lore raw

PATCH 1/1 hw-breakpoints: Fix unused function in off-case

In reply to Stephen Rothwell

bp_perf_event_destroy() is unused in its off-case version, let's remove it to fix the following warning:

kernel/perf_event.c:4306: warning: 'bp_perf_event_destroy' defined but not used

---
 kernel/perf_event.c |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)
kernel/perf_event.c +0 -4
index 35df94e..b119e4e 100644
@@ -4303,10 +4303,6 @@ void perf_bp_event(struct perf_event *bp, void *data)
 		perf_swevent_add(bp, 1, 1, &sample, regs);
 }
 #else
-static void bp_perf_event_destroy(struct perf_event *event)
-{
-}
-
 static const struct pmu *bp_perf_event_init(struct perf_event *bp)
 {
 	return NULL;
Signature · 1 line
1.6.2.3
#3 lore raw

[tip:perf/core] hw-breakpoints: Fix unused function in off-case

Commit-ID:  80bbf6b641c8843b9d751a1f299aa7ee073ab9d4
Gitweb:     http://git.kernel.org/tip/80bbf6b641c8843b9d751a1f299aa7ee073ab9d4
Author:     Frederic Weisbecker <[email protected]>
AuthorDate: Wed, 25 Nov 2009 21:20:53 +0100
Committer:  Ingo Molnar <[email protected]>
CommitDate: Thu, 26 Nov 2009 10:40:51 +0100

hw-breakpoints: Fix unused function in off-case

bp_perf_event_destroy() is unused in its off-case version, let's remove it to fix the following warning reported by Stephen Rothwell in linux-next:

kernel/perf_event.c:4306: warning: 'bp_perf_event_destroy' defined but not used

LKML-Reference: <[email protected]>

---
 kernel/perf_event.c |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)
kernel/perf_event.c +0 -4
index 34a1b9d..f8c7939 100644
@@ -4303,10 +4303,6 @@ void perf_bp_event(struct perf_event *bp, void *data)
 		perf_swevent_add(bp, 1, 1, &sample, regs);
 }
 #else
-static void bp_perf_event_destroy(struct perf_event *event)
-{
-}
-
 static const struct pmu *bp_perf_event_init(struct perf_event *bp)
 {
 	return NULL;