perf, tools, record: Support recording running/enabled time
PATCH 1/1 perf, tools, record: Support recording running/enabled time
From: Andi Kleen <[email protected]>
Add an option to perf record to record running/enabled time for read events, similar to what stat does.
This is useful to understand multiplexing problems.
Right now the report support is not great, but at least report -D already supports it.
--- tools/perf/Documentation/perf-record.txt | 3 +++ tools/perf/builtin-record.c | 2 ++ tools/perf/perf.h | 1 + tools/perf/util/evsel.c | 6 ++++++ 4 files changed, 12 insertions(+)
tools/perf/Documentation/perf-record.txt +3 -0
@@ -241,6 +241,9 @@ Capture machine state (registers) at interrupt, i.e., on counter overflows for each sample. List of captured registers depends on the architecture. This option is off by default. +--running:: +Record running and enabled time for read events (:S) + SEE ALSO -------- linkperf:perf-stat[1], linkperf:perf-list[1]
tools/perf/builtin-record.c +2 -0
@@ -839,6 +839,8 @@ struct option __record_options[] = { "use per-thread mmaps"),OPT_BOOLEAN ('I' ,"intr-regs" , &record.opts.sample_intr_regs,"Sample machine registers on interrupt" ), +OPT_BOOLEAN (0 ,"running-time" , &record.opts.running_time, +"Record running/enabled time of read (:S) events" ), OPT_END() };
tools/perf/perf.h +1 -0
@@ -53,6 +53,7 @@ struct record_opts {bool sample_time;bool period;bool sample_intr_regs; +bool running_time;unsigned int freq;unsigned int mmap_pages;unsigned int user_freq;
tools/perf/util/evsel.c +6 -0
@@ -734,6 +734,12 @@ void perf_evsel__config(struct perf_evsel *evsel, struct record_opts *opts)if (opts->sample_transaction)perf_evsel__set_sample_bit (evsel,TRANSACTION ); +if (opts->running_time) { + evsel->attr.read_format |= +PERF_FORMAT_TOTAL_TIME_ENABLED | +PERF_FORMAT_TOTAL_TIME_RUNNING ; + } +/* * XXX see the function comment above *
Signature · 1 line
1.9.3
Quoted 9 lines · Andi Kleen
From: Andi Kleen <[email protected]>
Add an option to perf record to record running/enabled time for read events, similar to what stat does.
This is useful to understand multiplexing problems.
Right now the report support is not great, but at least report -D already supports it.
yep, report -D displays it nicely
thanks,
jirka
Em Wed, Feb 25, 2015 at 04:13:06PM +0100, Jiri Olsa escreveu:
Quoted 6 lines · Andi Kleen
Quoted 5 lines
From: Andi Kleen <[email protected]>
Add an option to perf record to record running/enabled time for read events, similar to what stat does.
Quoted 8 lines
Quoted 4 lines
This is useful to understand multiplexing problems.
Right now the report support is not great, but at least report -D already supports it.
yep, report -D displays it nicely
Acked-by Jiri Olsa <[email protected]>
Thanks, applied.
- Arnaldo
Quoted 17 lines · Andi Kleen
tools/perf/Documentation/perf-record.txt +3
-0@@ -241,6 +241,9 @@ Capture machine state (registers) at interrupt, i.e., on counter overflows for each sample. List of captured registers depends on the architecture. This option is off by default. +--running:: +Record running and enabled time for read events (:S) + SEE ALSO -------- linkperf:perf-stat[1], linkperf:perf-list[1]tools/perf/builtin-record.c +0
-0
tools/perf/builtin-record.c struct option __record_options[] = { · line 844
Quoted 6 lines
tools/perf/builtin-record.c +2
-0@@ -839,6 +839,8 @@ struct option __record_options[] = { "use per-thread mmaps"),OPT_BOOLEAN ('I' ,"intr-regs" , &record.opts.sample_intr_regs,"Sample machine registers on interrupt" ), +OPT_BOOLEAN (0 ,"running-time" , &record.opts.running_time, +"Record running/enabled time of read (:S) events" ),OPT_END ()
Documentation differs from option in the record command.
David
tip-bot for Andi Kleen
merge bot[tip:perf/core] perf record: Support recording running/ enabled time
In reply to Andi Kleenperf record: Support recording running/enabled time
Commit-ID: 85c273d2b6569706762cf400079ca0699e007d81 Gitweb: http://git.kernel.org/tip/85c273d2b6569706762cf400079ca0699e007d81 Author: Andi Kleen <[email protected]> AuthorDate: Tue, 24 Feb 2015 15:13:40 -0800 Committer: Arnaldo Carvalho de Melo <[email protected]> CommitDate: Wed, 25 Feb 2015 12:42:23 -0300
perf record: Support recording running/enabled time
Add an option to perf record to record running/enabled time for read events, similar to what stat does.
This is useful to understand multiplexing problems.
Right now the report support is not great, but at least report -D already supports it.
--- tools/perf/Documentation/perf-record.txt | 3 +++ tools/perf/builtin-record.c | 2 ++ tools/perf/perf.h | 1 + tools/perf/util/evsel.c | 6 ++++++ 4 files changed, 12 insertions(+)
tools/perf/Documentation/perf-record.txt +3 -0
@@ -241,6 +241,9 @@ Capture machine state (registers) at interrupt, i.e., on counter overflows for each sample. List of captured registers depends on the architecture. This option is off by default. +--running-time:: +Record running and enabled time for read events (:S) + SEE ALSO -------- linkperf:perf-stat[1], linkperf:perf-list[1]
tools/perf/builtin-record.c +2 -0
@@ -839,6 +839,8 @@ struct option __record_options[] = { "use per-thread mmaps"),OPT_BOOLEAN ('I' ,"intr-regs" , &record.opts.sample_intr_regs,"Sample machine registers on interrupt" ), +OPT_BOOLEAN (0 ,"running-time" , &record.opts.running_time, +"Record running/enabled time of read (:S) events" ), OPT_END() };
tools/perf/perf.h +1 -0
@@ -53,6 +53,7 @@ struct record_opts {bool sample_time;bool period;bool sample_intr_regs; +bool running_time;unsigned int freq;unsigned int mmap_pages;unsigned int user_freq;
tools/perf/util/evsel.c +6 -0
@@ -734,6 +734,12 @@ void perf_evsel__config(struct perf_evsel *evsel, struct record_opts *opts)if (opts->sample_transaction)perf_evsel__set_sample_bit (evsel,TRANSACTION ); +if (opts->running_time) { + evsel->attr.read_format |= +PERF_FORMAT_TOTAL_TIME_ENABLED | +PERF_FORMAT_TOTAL_TIME_RUNNING ; + } +/* * XXX see the function comment above *