Skip to contentSkip to conversation

perf ui browser: Allow specifying message to show when no samples are available to display

tip: perf/core tip-bot2 for Arnaldo Carvalho de Melo 1 participant 1 message Aug 23, 2019 1 message not in the archive perf events

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

tip-bot2 for Arnaldo Carvalho de Melo

author merge bot Applied
#1 lore raw

The following commit has been merged into the perf/core branch of tip:

Commit-ID:     2284cf8074ff12b6304665618f81ced3aa0b41de
Gitweb:        https://git.kernel.org/tip/2284cf8074ff12b6304665618f81ced3aa0b41de
Author:        Arnaldo Carvalho de Melo <[email protected]>
AuthorDate:    Mon, 19 Aug 2019 16:43:58 -03:00
Committer:     Arnaldo Carvalho de Melo <[email protected]>
CommitterDate: Tue, 20 Aug 2019 12:22:18 -03:00

perf ui browser: Allow specifying message to show when no samples are available to display

The 'perf top' tool will use that to avoid having a initial blank screen while collecting the minimum number of samples to sort and display.

---
 tools/perf/ui/browser.c | 2 ++
 tools/perf/ui/browser.h | 1 +
 2 files changed, 3 insertions(+)
tools/perf/ui/browser.c +2 -0
index d227d74..c797a85 100644
@@ -347,6 +347,8 @@ static int __ui_browser__refresh(struct ui_browser *browser)
 	SLsmg_fill_region(browser->y + row + browser->extra_title_lines, browser->x,
 			  browser->rows - row, width, ' ');
 
+	if (browser->nr_entries == 0 && browser->no_samples_msg)
+		__ui__info_window(NULL, browser->no_samples_msg, NULL);
 	return 0;
 }
 
tools/perf/ui/browser.h +1 -0
index dc14441..3678eb8 100644
@@ -23,6 +23,7 @@ struct ui_browser {
 	void	      *priv;
 	const char    *title;
 	char	      *helpline;
+	const char    *no_samples_msg;
 	void 	      (*refresh_dimensions)(struct ui_browser *browser);
 	unsigned int  (*refresh)(struct ui_browser *browser);
 	void	      (*write)(struct ui_browser *browser, void *entry, int row);