perf stat: Fix endless wait for child process
PATCH 1/1 perf stat: Fix endless wait for child process
We hit a perf stat issue by using following script.
#!/bin/bash
sleep 1000 &
exec perf stat -a -e cycles -I1000 -- sleep 5
Since "perf stat" is launched by exec, so the "sleep 1000" would be the child process of "perf stat". The wait4() will not return because it's waiting for the child process "sleep 1000" to be end. So perf stat doesn't return even 5s passed.
This patch lets the perf stat return when the specified child process is end (in this case, specified child process is "sleep 5").
--- tools/perf/builtin-stat.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
tools/perf/builtin-stat.c +2 -1
@@ -561,7 +561,8 @@ static int __run_perf_stat(int argc, const char **argv, int run_idx)break ; } } -wait4 (child_pid, &status,0 , &stat_config.ru_data); +if (child_pid !=-1 ) +wait4 (child_pid, &status,0 , &stat_config.ru_data);if (workload_exec_errno) {const char *emsg =str_error_r (workload_exec_errno, msg,sizeof (msg));
Signature · 1 line
2.7.4
Quoted 12 lines · Jin Yao
We hit a perf stat issue by using following script.
#!/bin/bash
sleep 1000 &
exec perf stat -a -e cycles -I1000 -- sleep 5Since "perf stat" is launched by exec, so the "sleep 1000" would be the child process of "perf stat". The
wait4()will not return because it's waiting for the child process "sleep 1000" to be end. So perf stat doesn't return even 5s passed.
Quoted 4 lines
This patch lets the perf stat return when the specified child process is end (in this case, specified child process is "sleep 5").
Signed-off-by Jin Yao <[email protected]>
thanks,
jirka
Quoted 21 lines
--- tools/perf/builtin-stat.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)tools/perf/builtin-stat.c +2
-1@@ -561,7 +561,8 @@ static int __run_perf_stat(int argc, const char **argv, int run_idx)break ; } } -wait4 (child_pid, &status,0 , &stat_config.ru_data); +if (child_pid !=-1 ) +wait4 (child_pid, &status,0 , &stat_config.ru_data);if (workload_exec_errno) {const char *emsg =str_error_r (workload_exec_errno, msg,sizeof (msg));Signature · 1 line
2.7.4
Arnaldo Carvalho de Melo
maintainerEm Thu, Jan 03, 2019 at 12:12:05PM +0100, Jiri Olsa escreveu:
Quoted 13 lines · Jin Yao
Quoted 12 lines
We hit a perf stat issue by using following script.
#!/bin/bash
sleep 1000 &
exec perf stat -a -e cycles -I1000 -- sleep 5Since "perf stat" is launched by exec, so the "sleep 1000" would be the child process of "perf stat". The
wait4()will not return because it's waiting for the child process "sleep 1000" to be end. So perf stat doesn't return even 5s passed.
Quoted 6 lines
Quoted 4 lines
This patch lets the perf stat return when the specified child process is end (in this case, specified child process is "sleep 5").
Signed-off-by Jin Yao <[email protected]>Reviewed-by Jiri Olsa <[email protected]>
Thanks, tested and applied.
- Arnaldo
tip-bot for Jin Yao
merge botperf stat: Fix endless wait for child process
Commit-ID: 8a99255a50c0b4c2a449b96fd8d45fcc8d72c701 Gitweb: https://git.kernel.org/tip/8a99255a50c0b4c2a449b96fd8d45fcc8d72c701 Author: Jin Yao <[email protected]> AuthorDate: Thu, 3 Jan 2019 15:40:45 +0800 Committer: Arnaldo Carvalho de Melo <[email protected]> CommitDate: Thu, 3 Jan 2019 12:12:18 -0300
perf stat: Fix endless wait for child process
We hit a 'perf stat' issue by using following script:
#!/bin/bash
sleep 1000 &
exec perf stat -a -e cycles -I1000 -- sleep 5
Since "perf stat" is launched by exec, the "sleep 1000" would be the child process of "perf stat". The wait4() call will not return because it's waiting for the child process "sleep 1000" to end. So 'perf stat' doesn't return even after 5s passes.
This patch lets 'perf stat' return when the specified child process ends (in this case, the specified child process is "sleep 5").
Committer testing:
# cat test.sh #!/bin/bash
sleep 10 &
exec perf stat -a -e cycles -I1000 -- sleep 5
#
Before:
# time ./test.sh
# time counts unit events
1.001113090 108,453,351 cycles
2.002062196 142,075,435 cycles
3.002896194 164,801,068 cycles
4.003731666 107,062,140 cycles
5.002068867 112,241,832 cycles real 0m10.066s
user 0m0.016s
sys 0m0.101s
#
After:
# time ./test.sh
# time counts unit events
1.001016096 91,412,027 cycles
2.002014963 124,063,708 cycles
3.002883964 125,993,929 cycles
4.003706470 120,465,734 cycles
5.002006778 163,560,355 cycles real 0m5.123s
user 0m0.014s
sys 0m0.105s
#
--- tools/perf/builtin-stat.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
tools/perf/builtin-stat.c +2 -1
@@ -561,7 +561,8 @@ try_again:break ; } } -wait4 (child_pid, &status,0 , &stat_config.ru_data); +if (child_pid !=-1 ) +wait4 (child_pid, &status,0 , &stat_config.ru_data);if (workload_exec_errno) {const char *emsg =str_error_r (workload_exec_errno, msg,sizeof (msg));