Skip to contentSkip to conversation

x86,perf: fix comments in p4 pmu definitions

PATCH In review Lin Ming 1 participant 2 messages Mar 16, 2010 x86

lore
Share & tools
lore

Lin Ming

author
#0 lore raw

PATCH 1/1 x86,perf: fix comments in p4 pmu definitions

---
 arch/x86/include/asm/perf_event_p4.h |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)
arch/x86/include/asm/perf_event_p4.h +3 -2
index b47b9e9..b842b32 100644
@@ -319,6 +319,7 @@ static inline u32 p4_default_escr_conf(int cpu, int exclude_os, int exclude_usr)
 
 #define P4_BSQ_ACTIVE_ENTRIES		P4_EVENT_PACK(0x06, 0x07)
 	/*
+	 * NOTE: no ESCR name in docs, it's guessed
 	 * MSR_P4_BSU_ESCR1:	2, 3
 	 */
 
@@ -468,8 +469,8 @@ static inline u32 p4_default_escr_conf(int cpu, int exclude_os, int exclude_usr)
 
 #define P4_UOPS_RETIRED			P4_EVENT_PACK(0x01, 0x04)
 	/*
-	 * MSR_P4_CRU_ESCR2:	12, 13, 16
-	 * MSR_P4_CRU_ESCR3:	14, 15, 17
+	 * MSR_P4_CRU_ESCR0:	12, 13, 16
+	 * MSR_P4_CRU_ESCR1:	14, 15, 17
 	 */
 
 #define P4_UOP_TYPE			P4_EVENT_PACK(0x02, 0x02)
#1 lore raw

[tip:perf/core] x86, perf: Fix comments in Pentium-4 PMU definitions

Commit-ID:  8ea7f544100844307072cae2f5fc108afdef999a
Gitweb:     http://git.kernel.org/tip/8ea7f544100844307072cae2f5fc108afdef999a
Author:     Lin Ming <[email protected]>
AuthorDate: Tue, 16 Mar 2010 10:12:36 +0800
Committer:  Ingo Molnar <[email protected]>
CommitDate: Tue, 16 Mar 2010 09:37:46 +0100

x86, perf: Fix comments in Pentium-4 PMU definitions

Cc Peter Zijlstra <[email protected]>
Cc Mike Galbraith <[email protected]>
Cc Paul Mackerras <[email protected]>
Cc Arnaldo Carvalho de Melo <[email protected]>
Cc Frederic Weisbecker <[email protected]>

LKML-Reference: <[email protected]>

---
 arch/x86/include/asm/perf_event_p4.h |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)
arch/x86/include/asm/perf_event_p4.h +3 -2
index b47b9e9..b842b32 100644
@@ -319,6 +319,7 @@ static inline u32 p4_default_escr_conf(int cpu, int exclude_os, int exclude_usr)
 
 #define P4_BSQ_ACTIVE_ENTRIES		P4_EVENT_PACK(0x06, 0x07)
 	/*
+	 * NOTE: no ESCR name in docs, it's guessed
 	 * MSR_P4_BSU_ESCR1:	2, 3
 	 */
 
@@ -468,8 +469,8 @@ static inline u32 p4_default_escr_conf(int cpu, int exclude_os, int exclude_usr)
 
 #define P4_UOPS_RETIRED			P4_EVENT_PACK(0x01, 0x04)
 	/*
-	 * MSR_P4_CRU_ESCR2:	12, 13, 16
-	 * MSR_P4_CRU_ESCR3:	14, 15, 17
+	 * MSR_P4_CRU_ESCR0:	12, 13, 16
+	 * MSR_P4_CRU_ESCR1:	14, 15, 17
 	 */
 
 #define P4_UOP_TYPE			P4_EVENT_PACK(0x02, 0x02)