perf report: Display user/kernel differentiator
Commit-ID: 8edd4286f99f78fe07fe9196e69d5643da86cada Gitweb: http://git.kernel.org/tip/8edd4286f99f78fe07fe9196e69d5643da86cada Author: Ingo Molnar <[email protected]> AuthorDate: Fri, 5 Jun 2009 14:13:18 +0200 Committer: Ingo Molnar <[email protected]> CommitDate: Fri, 5 Jun 2009 14:13:18 +0200
perf report: Display user/kernel differentiator
Before:
25.96% copy_user_generic_string
15.23% two_op
15.19% one_op
6.92% enough_duration
1.23% alloc_pages_current
1.14% acpi_os_read_port
1.08% _spin_lockAfter:
25.96% [k] copy_user_generic_string
15.23% [.] two_op
15.19% [.] one_op
6.92% [.] enough_duration
1.23% [k] alloc_pages_current
1.14% [k] acpi_os_read_port
1.08% [k] _spin_lockThe '[k]' differentiator is a quick clue that it's a kernel symbol, without having to bring in the full dso column.
Acked-by Peter Zijlstra <[email protected]>
Cc Mike Galbraith <[email protected]>
Cc Paul Mackerras <[email protected]>
Cc Arnaldo Carvalho de Melo <[email protected]>
LKML-Reference: <new-submission>
Signed-off-by Ingo Molnar <[email protected]>
--- Documentation/perf_counter/builtin-report.c | 16 +++++++++------- 1 files changed, 9 insertions(+), 7 deletions(-)
Documentation/perf_counter/builtin-report.c +9 -7
@@ -504,7 +504,7 @@ sort__comm_print(FILE *fp, struct hist_entry *self) }static struct sort_entry sort_comm = { - .header =" Command" , + .header =" Command" , .cmp = sort__comm_cmp, .collapse = sort__comm_collapse, .print = sort__comm_print,
@@ -569,10 +569,12 @@ sort__sym_print(FILE *fp, struct hist_entry *self)if (verbose) ret +=fprintf (fp,"%#018llx " , (__u64 )self->ip); -if (self->sym) - ret +=fprintf (fp,"%s" , self->sym->name); -else +if (self->sym) { + ret +=fprintf (fp,"[%c] %s" , + self->dso == kernel_dso ?'k' :'.' , self->sym->name); + }else { ret +=fprintf (fp,"%#016llx" , (__u64 )self->ip); + }return ret; }
@@ -586,9 +588,9 @@ static struct sort_entry sort_sym = {static int sort__need_collapse =0 ;struct sort_dimension { -char *name; -struct sort_entry *entry; -int taken; +char *name; +struct sort_entry *entry; +int taken; };static struct sort_dimension sort_dimensions[] = {