Skip to contentSkip to conversation

perf timechart: Use tid not pid for COMM change

PATCH In review Arjan van de Ven 2 participants 2 messages Jan 16, 2010 – Jan 17, 2010 perf events

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 perf timechart: Use tid not pid for COMM change

Quoted 1 line

From 3e519cea7bbc7c6a3c07e3a24e9f33bf15305516 Mon Sep 17 00:00:00 2001

From: Arjan van de Ven <[email protected]>
Date: Sat, 16 Jan 2010 12:51:30 -0800
Subject: [PATCH] perf timechart: Use tid not pid for COMM change

A process that changes its comm field, does this on a per kernel task struct basis. The timechart tool used, incorrectly, the pid to track this, and should have used the tid instead...

---
 tools/perf/builtin-timechart.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
tools/perf/builtin-timechart.c +1 -1
index a589a43..3f8bbcf 100644
@@ -280,7 +280,7 @@ static u64 cpus_pstate_state[MAX_CPUS];
 
 static int process_comm_event(event_t *event, struct perf_session *session __used)
 {
-	pid_set_comm(event->comm.pid, event->comm.comm);
+	pid_set_comm(event->comm.tid, event->comm.comm);
 	return 0;
 }
 
Signature · 8 lines
1.6.2.5



-- 
Arjan van de Ven 	Intel Open Source Technology Centre
For development, discussion and tips for power savings, 
visit http://www.lesswatts.org
#1 lore raw
Commit-ID:  8f06d7e6e1bbfb32698d6d455583ab7460c090e2
Gitweb:     http://git.kernel.org/tip/8f06d7e6e1bbfb32698d6d455583ab7460c090e2
Author:     Arjan van de Ven <[email protected]>
AuthorDate: Sat, 16 Jan 2010 12:53:19 -0800
Committer:  Ingo Molnar <[email protected]>
CommitDate: Sun, 17 Jan 2010 07:16:36 +0100

perf timechart: Use tid not pid for COMM change

A process that changes its comm field, does this on a per kernel task struct basis. The timechart tool used, incorrectly, the pid to track this, and should have used the tid instead...

Cc Peter Zijlstra <[email protected]>
Cc Mike Galbraith <[email protected]>
Cc Paul Mackerras <[email protected]>
Cc Arnaldo Carvalho de Melo <[email protected]>
Cc Frederic Weisbecker <[email protected]>

LKML-Reference: <[email protected]>

---
 tools/perf/builtin-timechart.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
tools/perf/builtin-timechart.c +1 -1
index a589a43..3f8bbcf 100644
@@ -280,7 +280,7 @@ static u64 cpus_pstate_state[MAX_CPUS];
 
 static int process_comm_event(event_t *event, struct perf_session *session __used)
 {
-	pid_set_comm(event->comm.pid, event->comm.comm);
+	pid_set_comm(event->comm.tid, event->comm.comm);
 	return 0;
 }