Skip to contentSkip to conversation

sched: Fix !CONFIG_SCHED_NUMA account_numa_enqueue () variant

tip:numa/core tip-bot for Ingo Molnar 1 participant 1 message Oct 20, 2012 Scheduler

lore
Share & tools
lore
#0 lore raw
Commit-ID:  9744d7978477bddc141284876b6544f3d8f7dbd8
Gitweb:     http://git.kernel.org/tip/9744d7978477bddc141284876b6544f3d8f7dbd8
Author:     Ingo Molnar <[email protected]>
AuthorDate: Sat, 20 Oct 2012 02:22:53 +0200
Committer:  Ingo Molnar <[email protected]>
CommitDate: Sat, 20 Oct 2012 03:12:17 +0200

sched: Fix !CONFIG_SCHED_NUMA account_numa_enqueue() variant

This build warning:

kernel/sched/fair.c:1015:1: warning: no return statement in function returning non-void

Triggers because the dummy account_numa_enqueue() should return the rq's task list.

It's not possible to trigger this bug runtime, nevertheless fix the warning.

---
 kernel/sched/fair.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
kernel/sched/fair.c +1 -0
index e93032d..a66a1b6 100644
@@ -967,6 +967,7 @@ void task_tick_numa(struct rq *rq, struct task_struct *curr)
 #else
 static struct list_head *account_numa_enqueue(struct rq *rq, struct task_struct *p)
 {
+	return NULL;
 }
 
 static void account_numa_dequeue(struct rq *rq, struct task_struct *p)