Skip to contentSkip to conversation

Subject: [PATCH 1/2] fix a Section mismatch in arch/x86/kernel/setup.c

PATCH Helight.Xu 1 participant 2 messages Nov 30, 2009 x86

lore
Share & tools
lore

Helight.Xu

author
#0 lore raw

copy_edd() should be __init.
warning msg:
WARNING: vmlinux.o(.text+0x7759): Section mismatch in reference from the function copy_edd() to the variable .init.data:boot_params The function copy_edd() references
the variable __initdata boot_params.
This is often because copy_edd lacks a __initdata
annotation or the annotation of boot_params is wrong.

---
arch/x86/kernel/setup.c | 4 ++--

1 files changed, 2 insertions(+), 2 deletions(-)
arch/x86/kernel/setup.c +1 -1
index 2a34f9c..24e50d6 100644
@@ -247,7 +247,7 @@ EXPORT_SYMBOL(edd);
 *              from boot_params into a safe place.
 *
 */
-static inline void copy_edd(void)
+static inline void __init copy_edd(void)
{
     memcpy(edd.mbr_signature, boot_params.edd_mbr_sig_buffer,
           sizeof(edd.mbr_signature));
@@ -256,7 +256,7 @@ static inline void copy_edd(void)
     edd.edd_info_nr = boot_params.eddbuf_entries;
}

#else
-static inline void copy_edd(void)
+static inline void __init copy_edd(void)
{
}
#endif

Signature · 6 lines
1.6.5.3

-- 
---------------------------------
Zhenwen Xu - Open and Free
Home Page:	http://zhwen.org
#1 lore raw

[tip:x86/cleanups] x86: Fix a section mismatch in arch/x86/kernel/setup.c

Commit-ID:  9eaa192d8988d621217a9e6071cd403fd6010496
Gitweb:     http://git.kernel.org/tip/9eaa192d8988d621217a9e6071cd403fd6010496
Author:     Helight.Xu <[email protected]>
AuthorDate: Mon, 30 Nov 2009 18:33:51 +0800
Committer:  H. Peter Anvin <[email protected]>
CommitDate: Mon, 30 Nov 2009 11:16:49 -0800

x86: Fix a section mismatch in arch/x86/kernel/setup.c

copy_edd() should be __init.
warning msg:
WARNING: vmlinux.o(.text+0x7759): Section mismatch in reference from the function copy_edd() to the variable .init.data:boot_params The function copy_edd() references
the variable __initdata boot_params.
This is often because copy_edd lacks a __initdata
annotation or the annotation of boot_params is wrong.

LKML-Reference: <[email protected]>

---
 arch/x86/kernel/setup.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
arch/x86/kernel/setup.c +2 -2
index e09f0e2..e020b2d 100644
@@ -247,7 +247,7 @@ EXPORT_SYMBOL(edd);
  *              from boot_params into a safe place.
  *
  */
-static inline void copy_edd(void)
+static inline void __init copy_edd(void)
 {
      memcpy(edd.mbr_signature, boot_params.edd_mbr_sig_buffer,
 	    sizeof(edd.mbr_signature));
@@ -256,7 +256,7 @@ static inline void copy_edd(void)
      edd.edd_info_nr = boot_params.eddbuf_entries;
 }
 #else
-static inline void copy_edd(void)
+static inline void __init copy_edd(void)
 {
 }
 #endif