sched,trace: Allow tracing the preemption decision on wakeup
Peter Zijlstra
maintainerPATCH 1/1 sched,trace: Allow tracing the preemption decision on wakeup
Thomas noted that we do the wakeup preemption check after the wakeup trace point, this means the tracepoint cannot test/report this decision; which is rather important for latency sensitive workloads. Therefore move the tracepoint after doing the preemption check.
--- kernel/sched/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/sched/core.c +1 -1
@@ -1288,8 +1288,8 @@ static void ttwu_activate(struct rq *rq, struct task_struct *p, int en_flags)static void ttwu_do_wakeup (struct rq *rq,struct task_struct *p,int wake_flags) { -trace_sched_wakeup (p, true);check_preempt_curr (rq, p, wake_flags); +trace_sched_wakeup (p, true); p->state =TASK_RUNNING ;#ifdef CONFIG_SMP
Quoted 7 lines · Peter Zijlstra
Thomas noted that we do the wakeup preemption check after the wakeup trace point, this means the tracepoint cannot test/report this decision; which is rather important for latency sensitive workloads. Therefore move the tracepoint after doing the preemption check.
Suggested-by Thomas Gleixner <[email protected]>Signed-off-by Peter Zijlstra <[email protected]>
Quoted 19 lines
--- kernel/sched/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)kernel/sched/core.c +1
-1@@ -1288,8 +1288,8 @@ static void ttwu_activate(struct rq *rq, struct task_struct *p, int en_flags)static void ttwu_do_wakeup (struct rq *rq,struct task_struct *p,int wake_flags) { -trace_sched_wakeup (p, true);check_preempt_curr (rq, p, wake_flags); +trace_sched_wakeup (p, true); p->state =TASK_RUNNING ;#ifdef CONFIG_SMP
Yeah -- this one is a real no brainer to move; looks good :)
Quoted 32 lines · Steven Rostedt
Quoted 7 lines · Peter Zijlstra
Thomas noted that we do the wakeup preemption check after the wakeup trace point, this means the tracepoint cannot test/report this decision; which is rather important for latency sensitive workloads. Therefore move the tracepoint after doing the preemption check.
Suggested-by Thomas Gleixner <[email protected]>Signed-off-by Peter Zijlstra <[email protected]>Acked-by Steven Rostedt <[email protected]>Quoted 19 lines
--- kernel/sched/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)kernel/sched/core.c +1
-1@@ -1288,8 +1288,8 @@ static void ttwu_activate(struct rq *rq, struct task_struct *p, int en_flags)static void ttwu_do_wakeup (struct rq *rq,struct task_struct *p,int wake_flags) { -trace_sched_wakeup (p, true);check_preempt_curr (rq, p, wake_flags); +trace_sched_wakeup (p, true); p->state =TASK_RUNNING ;#ifdef CONFIG_SMP
tip-bot for Peter Zijlstra
merge bot[tip:sched/core] sched/tracing: Allow tracing the preemption decision on wakeup
In reply to Peter Zijlstrasched/tracing: Allow tracing the preemption decision on wakeup
Commit-ID: a8d7ad52a7befbde896276d05c75c90fed48b5bf Gitweb: http://git.kernel.org/tip/a8d7ad52a7befbde896276d05c75c90fed48b5bf Author: Peter Zijlstra <[email protected]> AuthorDate: Thu, 14 Mar 2013 10:48:39 +0100 Committer: Ingo Molnar <[email protected]> CommitDate: Mon, 18 Mar 2013 10:18:08 +0100
sched/tracing: Allow tracing the preemption decision on wakeup
Thomas noted that we do the wakeup preemption check after the wakeup trace point, this means the tracepoint cannot test/report this decision; which is rather important for latency sensitive workloads. Therefore move the tracepoint after doing the preemption check.
--- kernel/sched/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/sched/core.c +1 -1
@@ -1288,8 +1288,8 @@ static void ttwu_activate(struct rq *rq, struct task_struct *p, int en_flags)static void ttwu_do_wakeup (struct rq *rq,struct task_struct *p,int wake_flags) { -trace_sched_wakeup (p, true);check_preempt_curr (rq, p, wake_flags); +trace_sched_wakeup (p, true); p->state =TASK_RUNNING ;#ifdef CONFIG_SMP