Skip to contentSkip to conversation

sched: cleanup: remove unused variable in try_to_wake_up()

PATCH In review Dan Carpenter 1 participant 2 messages Mar 6, 2010 – Mar 11, 2010 Kernel janitors

lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/1 sched: cleanup: remove unused variable in try_to_wake_up()

We haven't used the "orig_rq" variable since 055a00865d "Fix/add missing update_rq_clock() calls"

Signed-off-by Dan Carpenter <[email protected]>
kernel/sched.c +2 -2
index abb36b1..523c750 100644
@@ -2359,7 +2359,7 @@ static int try_to_wake_up(struct task_struct *p, unsigned int state,
 {
 	int cpu, orig_cpu, this_cpu, success = 0;
 	unsigned long flags;
-	struct rq *rq, *orig_rq;
+	struct rq *rq;
 
 	if (!sched_feat(SYNC_WAKEUPS))
 		wake_flags &= ~WF_SYNC;

@@ -2367,7 +2367,7 @@ static int try_to_wake_up(struct task_struct *p, unsigned int state,
 	this_cpu = get_cpu();
 
 	smp_wmb();
-	rq = orig_rq = task_rq_lock(p, &flags);
+	rq = task_rq_lock(p, &flags);
 	update_rq_clock(rq);
 	if (!(p->state & state))
 		goto out;
author
#1 lore raw

[tip:sched/core] sched: Cleanup: remove unused variable in try_to_wake_up()

Commit-ID:  ab3b3aa5dd01b3aaa6b15caee113b21b1b6520c4
Gitweb:     http://git.kernel.org/tip/ab3b3aa5dd01b3aaa6b15caee113b21b1b6520c4
Author:     Dan Carpenter <[email protected]>
AuthorDate: Sat, 6 Mar 2010 14:17:52 +0300
Committer:  Ingo Molnar <[email protected]>
CommitDate: Thu, 11 Mar 2010 13:59:59 +0100

sched: Cleanup: remove unused variable in try_to_wake_up()

We haven't used the "orig_rq" variable since 055a00865d "Fix/add missing update_rq_clock() calls"

Signed-off-by Dan Carpenter <[email protected]>
Cc Peter Zijlstra <[email protected]>
Cc Andreas Herrmann <[email protected]>
Cc Gautham R Shenoy <[email protected]>
Cc [email protected]

LKML-Reference: <20100306111752.GL4958@bicker>

Signed-off-by Ingo Molnar <[email protected]>
---
 kernel/sched.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
kernel/sched.c +2 -2
index 6a212c9..2c1db81 100644
@@ -2359,7 +2359,7 @@ static int try_to_wake_up(struct task_struct *p, unsigned int state,
 {
 	int cpu, orig_cpu, this_cpu, success = 0;
 	unsigned long flags;
-	struct rq *rq, *orig_rq;
+	struct rq *rq;
 
 	if (!sched_feat(SYNC_WAKEUPS))
 		wake_flags &= ~WF_SYNC;

@@ -2367,7 +2367,7 @@ static int try_to_wake_up(struct task_struct *p, unsigned int state,
 	this_cpu = get_cpu();
 
 	smp_wmb();
-	rq = orig_rq = task_rq_lock(p, &flags);
+	rq = task_rq_lock(p, &flags);
 	update_rq_clock(rq);
 	if (!(p->state & state))
 		goto out;