perf trace: Make command line arguments consistent with perf-record - v3
PATCH 1/1 perf trace: Make command line arguments consistent with perf-record - v3
Common arguments like thread id, CPU list, mmap pages, etc should be consistent across perf commands.
v3: Updated man page
v2: rebased to latest core branch
Signed-off-by David Ahern <[email protected]>
--- tools/perf/Documentation/perf-trace.txt | 6 ++++++ tools/perf/builtin-trace.c | 12 ++++++------ 2 files changed, 12 insertions(+), 6 deletions(-)
tools/perf/Documentation/perf-trace.txt +6 -0
@@ -23,6 +23,7 @@ analysis phases. OPTIONS ------- +-a:: --all-cpus:: System-wide collection from all CPUs.
@@ -38,18 +39,23 @@ OPTIONS --pid=:: Record events on existing process ID (comma separated list). +-t:: --tid=:: Record events on existing thread ID (comma separated list). +-u:: --uid=:: Record events in threads owned by uid. Name or number. +-i:: --no-inherit:: Child tasks do not inherit counters. +-m:: --mmap-pages=:: Number of mmap data pages. Must be a power of two. +-C:: --cpu:: Collect samples only on the list of CPUs provided. Multiple CPUs can be provided as a comma-separated list with no space: 0,1. Ranges of CPUs are specified with -: 0-2.
tools/perf/builtin-trace.c +6 -6
@@ -693,17 +693,17 @@ int cmd_trace(int argc, const char **argv, const char *prefix __maybe_unused)OPT_STRING ('o' ,"output" , &output_name,"file" ,"output file name" ),OPT_STRING ('p' ,"pid" , &trace.opts.target.pid,"pid" ,"trace events on existing process id" ), -OPT_STRING (0 ,"tid" , &trace.opts.target.tid,"tid" , +OPT_STRING ('t' ,"tid" , &trace.opts.target.tid,"tid" ,"trace events on existing thread id" ), -OPT_BOOLEAN (0 ,"all-cpus" , &trace.opts.target.system_wide, +OPT_BOOLEAN ('a' ,"all-cpus" , &trace.opts.target.system_wide,"system-wide collection from all CPUs" ), -OPT_STRING (0 ,"cpu" , &trace.opts.target.cpu_list,"cpu" , +OPT_STRING ('C' ,"cpu" , &trace.opts.target.cpu_list,"cpu" ,"list of cpus to monitor" ), -OPT_BOOLEAN (0 ,"no-inherit" , &trace.opts.no_inherit, +OPT_BOOLEAN ('i' ,"no-inherit" , &trace.opts.no_inherit,"child tasks do not inherit counters" ), -OPT_UINTEGER (0 ,"mmap-pages" , &trace.opts.mmap_pages, +OPT_UINTEGER ('m' ,"mmap-pages" , &trace.opts.mmap_pages,"number of mmap data pages" ), -OPT_STRING (0 ,"uid" , &trace.opts.target.uid_str,"user" , +OPT_STRING ('u' ,"uid" , &trace.opts.target.uid_str,"user" ,"user to profile" ), OPT_CALLBACK(0, "duration", &trace, "float", "show only events with duration > N.M ms",
Signature · 1 line
1.7.10.1
Arnaldo Carvalho de Melo
AppliedEm Tue, Aug 20, 2013 at 11:15:45AM -0600, David Ahern escreveu:
Quoted 5 lines
Common arguments like thread id, CPU list, mmap pages, etc should be consistent across perf commands.
v3: Updated man page
v2: rebased to latest core branch
Thanks, applied.
- Arnaldo
tip-bot for David Ahern
merge bot[tip:perf/core] perf trace: Make command line arguments consistent with perf-record
In reply to David Ahernperf trace: Make command line arguments consistent with perf-record
Commit-ID: ac9be8ee4ecdeae73c78d84ebfe37009e11cf99d Gitweb: http://git.kernel.org/tip/ac9be8ee4ecdeae73c78d84ebfe37009e11cf99d Author: David Ahern <[email protected]> AuthorDate: Tue, 20 Aug 2013 11:15:45 -0600 Committer: Arnaldo Carvalho de Melo <[email protected]> CommitDate: Mon, 26 Aug 2013 17:25:35 -0300
perf trace: Make command line arguments consistent with perf-record
Common arguments like thread id, CPU list, mmap pages, etc should be consistent across perf commands.
v3: Updated man page
v2: rebased to latest core branch
Signed-off-by David Ahern <[email protected]>
Signed-off-by Arnaldo Carvalho de Melo <[email protected]>
--- tools/perf/Documentation/perf-trace.txt | 6 ++++++ tools/perf/builtin-trace.c | 12 ++++++------ 2 files changed, 12 insertions(+), 6 deletions(-)
tools/perf/Documentation/perf-trace.txt +6 -0
@@ -23,6 +23,7 @@ analysis phases. OPTIONS ------- +-a:: --all-cpus:: System-wide collection from all CPUs.
@@ -38,18 +39,23 @@ OPTIONS --pid=:: Record events on existing process ID (comma separated list). +-t:: --tid=:: Record events on existing thread ID (comma separated list). +-u:: --uid=:: Record events in threads owned by uid. Name or number. +-i:: --no-inherit:: Child tasks do not inherit counters. +-m:: --mmap-pages=:: Number of mmap data pages. Must be a power of two. +-C:: --cpu:: Collect samples only on the list of CPUs provided. Multiple CPUs can be provided as a comma-separated list with no space: 0,1. Ranges of CPUs are specified with -: 0-2.
tools/perf/builtin-trace.c +6 -6
@@ -693,17 +693,17 @@ int cmd_trace(int argc, const char **argv, const char *prefix __maybe_unused)OPT_STRING ('o' ,"output" , &output_name,"file" ,"output file name" ),OPT_STRING ('p' ,"pid" , &trace.opts.target.pid,"pid" ,"trace events on existing process id" ), -OPT_STRING (0 ,"tid" , &trace.opts.target.tid,"tid" , +OPT_STRING ('t' ,"tid" , &trace.opts.target.tid,"tid" ,"trace events on existing thread id" ), -OPT_BOOLEAN (0 ,"all-cpus" , &trace.opts.target.system_wide, +OPT_BOOLEAN ('a' ,"all-cpus" , &trace.opts.target.system_wide,"system-wide collection from all CPUs" ), -OPT_STRING (0 ,"cpu" , &trace.opts.target.cpu_list,"cpu" , +OPT_STRING ('C' ,"cpu" , &trace.opts.target.cpu_list,"cpu" ,"list of cpus to monitor" ), -OPT_BOOLEAN (0 ,"no-inherit" , &trace.opts.no_inherit, +OPT_BOOLEAN ('i' ,"no-inherit" , &trace.opts.no_inherit,"child tasks do not inherit counters" ), -OPT_UINTEGER (0 ,"mmap-pages" , &trace.opts.mmap_pages, +OPT_UINTEGER ('m' ,"mmap-pages" , &trace.opts.mmap_pages,"number of mmap data pages" ), -OPT_STRING (0 ,"uid" , &trace.opts.target.uid_str,"user" , +OPT_STRING ('u' ,"uid" , &trace.opts.target.uid_str,"user" ,"user to profile" ), OPT_CALLBACK(0, "duration", &trace, "float", "show only events with duration > N.M ms",