Skip to contentSkip to conversation

intel_mid: do not re-introduce usage of obsolete __cpuinit

PATCH In review Paul Gortmaker 3 participants 3 messages Nov 7, 2013

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 intel_mid: do not re-introduce usage of obsolete __cpuinit

The commit 712b6aa8731a7e148298c58cea66a5209c659e3c [Nov7 linux-next via tip/auto-latest] ("intel_mid: Renamed *mrst* to *intel_mid*") adds a __cpuinit.

We removed this a couple versions ago; we now want to remove the compat no-op stubs. Introducing new users is not what we want to see at this point in time, as it will break once the stubs are gone.

Cc Kuppuswamy Sathyanarayanan <[email protected]>
Cc David Cohen <[email protected]>
Cc H. Peter Anvin <[email protected]>

---

[Feel free to squash this into the original, if there happens
to be a rebase taking place anyway...]

 arch/x86/platform/intel-mid/intel-mid.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/x86/platform/intel-mid/intel-mid.c +1 -1
index 523a1c8..f90e290 100644
@@ -123,7 +123,7 @@ static void __init intel_mid_time_init(void)
 	apbt_time_init();
 }
 
-static void __cpuinit intel_mid_arch_setup(void)
+static void intel_mid_arch_setup(void)
 {
 	if (boot_cpu_data.x86 == 6 && boot_cpu_data.x86_model == 0x27)
 		__intel_mid_cpu_chip = INTEL_MID_CPU_CHIP_PENWELL;
Signature · 1 line
1.8.4.1
#1 lore raw

[tip:x86/intel-mid] x86, intel-mid: Do not re-introduce usage of obsolete __cpuinit

x86, intel-mid: Do not re-introduce usage of obsolete __cpuinit
Commit-ID:  aeeca404266c8ed2997905afc342ba9561f49ca7
Gitweb:     http://git.kernel.org/tip/aeeca404266c8ed2997905afc342ba9561f49ca7
Author:     Paul Gortmaker <[email protected]>
AuthorDate: Thu, 7 Nov 2013 13:34:50 -0500
Committer:  H. Peter Anvin <[email protected]>
CommitDate: Thu, 7 Nov 2013 10:44:03 -0800

x86, intel-mid: Do not re-introduce usage of obsolete __cpuinit

The commit 712b6aa8731a7e148298c58cea66a5209c659e3c [Nov7 linux-next via tip/auto-latest] ("intel_mid: Renamed *mrst* to *intel_mid*") adds a __cpuinit.

We removed this a couple versions ago; we now want to remove the compat no-op stubs. Introducing new users is not what we want to see at this point in time, as it will break once the stubs are gone.

---
 arch/x86/platform/intel-mid/intel-mid.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/x86/platform/intel-mid/intel-mid.c +1 -1
index 523a1c8..f90e290 100644
@@ -123,7 +123,7 @@ static void __init intel_mid_time_init(void)
 	apbt_time_init();
 }
 
-static void __cpuinit intel_mid_arch_setup(void)
+static void intel_mid_arch_setup(void)
 {
 	if (boot_cpu_data.x86 == 6 && boot_cpu_data.x86_model == 0x27)
 		__intel_mid_cpu_chip = INTEL_MID_CPU_CHIP_PENWELL;
Acked-by on v1 1/1
#2 lore raw
In reply to Paul Gortmaker
Quoted 9 lines · Paul Gortmaker

The commit 712b6aa8731a7e148298c58cea66a5209c659e3c [Nov7 linux-next via tip/auto-latest] ("intel_mid: Renamed *mrst* to *intel_mid*") adds a __cpuinit.

We removed this a couple versions ago; we now want to remove the compat no-op stubs. Introducing new users is not what we want to see at this point in time, as it will break once the stubs are gone.

Quoted 4 lines
Cc Kuppuswamy Sathyanarayanan <[email protected]>
Cc David Cohen <[email protected]>
Cc H. Peter Anvin <[email protected]>