perf report: Use ui__warning in some more places
Commit-ID: 00894ce9b85887caa0c16e18757004b9cc9f64cf Gitweb: http://git.kernel.org/tip/00894ce9b85887caa0c16e18757004b9cc9f64cf Author: Arnaldo Carvalho de Melo <[email protected]> AuthorDate: Wed, 3 Aug 2011 12:33:24 -0300 Committer: Arnaldo Carvalho de Melo <[email protected]> CommitDate: Wed, 3 Aug 2011 12:33:24 -0300
perf report: Use ui__warning in some more places
So that we get a proper warning in the TUI in cases like:
$ perf report --stdio -g fractal,0.5,caller --sort pid Selected -g but no callchain data. Did you call 'perf record' without -g? $
The --stdio case is ok because it uses fprintf, ui__warning is needed to figure out if --stdio or --tui is being used.
Cc Arun Sharma <[email protected]>
Cc David Ahern <[email protected]>
Cc Frederic Weisbecker <[email protected]>
Cc Mike Galbraith <[email protected]>
Cc Paul Mackerras <[email protected]>
Cc Peter Zijlstra <[email protected]>
Cc Sam Liao <[email protected]>
Cc Stephane Eranian <[email protected]>
Signed-off-by Arnaldo Carvalho de Melo <[email protected]>
--- tools/perf/builtin-report.c | 15 +++++++-------- 1 files changed, 7 insertions(+), 8 deletions(-)
tools/perf/builtin-report.c +7 -8
@@ -162,23 +162,22 @@ static int perf_session__setup_sample_type(struct perf_session *self) {if (!(self->sample_type &PERF_SAMPLE_CALLCHAIN )) {if (sort__has_parent) { -fprintf (stderr,"selected --sort parent, but no" -" callchain data. Did you call" -" perf record without -g?\n" ); +ui__warning ("Selected --sort parent, but no " +"callchain data. Did you call " +"'perf record' without -g?\n" );return -EINVAL ; }if (symbol_conf.use_callchain) { -fprintf (stderr,"selected -g but no callchain data." -" Did you call perf record without" -" -g?\n" ); +ui__warning ("Selected -g but no callchain data. Did " +"you call 'perf record' without -g?\n" );return -1 ; } }else if (!dont_use_callchains && callchain_param.mode !=CHAIN_NONE && !symbol_conf.use_callchain) { symbol_conf.use_callchain = true;if (callchain_register_param (&callchain_param) <0 ) { -fprintf (stderr,"Can't register callchain" -" params\n" ); +ui__warning ("Can't register callchain " +"params.\n" );return -EINVAL ; } }