Skip to contentSkip to conversation

perf top: Default to system wide using perf_target methods

tip:perf/core tip-bot for Arnaldo Carvalho de Melo 1 participant 1 message May 11, 2012 perf events

lore
Share & tools
lore
#0 lore raw
Commit-ID:  80eebd94d2090cf9e13ecdc305a0cf7996fa0070
Gitweb:     http://git.kernel.org/tip/80eebd94d2090cf9e13ecdc305a0cf7996fa0070
Author:     Arnaldo Carvalho de Melo <[email protected]>
AuthorDate: Tue, 8 May 2012 10:47:09 -0300
Committer:  Arnaldo Carvalho de Melo <[email protected]>
CommitDate: Tue, 8 May 2012 10:47:09 -0300

perf top: Default to system wide using perf_target methods

Additionally we were not checking if a cpu list had been provided by the user. Fix that.

---
 tools/perf/builtin-top.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)
tools/perf/builtin-top.c +1 -2
index e4ca827..c53cdab 100644
@@ -1270,8 +1270,7 @@ int cmd_top(int argc, const char **argv, const char *prefix __used)
 		goto out_delete_evlist;
 	}
 
-	if (top.target.tid == 0 && top.target.pid == 0 &&
-	    top.target.uid_str == NULL)
+	if (perf_target__none(&top.target))
 		top.target.system_wide = true;
 
 	if (perf_evlist__create_maps(top.evlist, &top.target) < 0)