Skip to contentSkip to conversation

irqchip: crossbar: Fix incorrect type of local variables

PATCH New Franck Demathieu 2 participants 2 messages Feb 23, 2017 – Mar 1, 2017 irqchip drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 irqchip: crossbar: Fix incorrect type of local variables

The max and entry variables are unsigned according to the dt-bindings. Fix following 3 sparse issues (-Wtypesign):

drivers/irqchip/irq-crossbar.c:222:52: warning: incorrect type in argument 3 (different signedness)
drivers/irqchip/irq-crossbar.c:222:52: expected unsigned int [usertype] *out_value
drivers/irqchip/irq-crossbar.c:222:52: got int *<noident>

drivers/irqchip/irq-crossbar.c:245:56: warning: incorrect type in argument 4 (different signedness)
drivers/irqchip/irq-crossbar.c:245:56: expected unsigned int [usertype] *out_value
drivers/irqchip/irq-crossbar.c:245:56: got int *<noident>

drivers/irqchip/irq-crossbar.c:263:56: warning: incorrect type in argument 4 (different signedness)
drivers/irqchip/irq-crossbar.c:263:56: expected unsigned int [usertype] *out_value
drivers/irqchip/irq-crossbar.c:263:56: got int *<noident>

---
 drivers/irqchip/irq-crossbar.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/irqchip/irq-crossbar.c +2 -1
index 1eef56a..05bbf17 100644
@@ -198,7 +198,8 @@ static int crossbar_domain_translate(struct irq_domain *d,
 
 static int __init crossbar_of_init(struct device_node *node)
 {
-	int i, size, max = 0, reserved = 0, entry;
+	int i, size, reserved = 0;
+	u32 max = 0, entry;
 	const __be32 *irqsr;
 	int ret = -ENOMEM;
 
Signature · 1 line
1.7.9.5
#1 lore raw

[tip:irq/urgent] irqchip/crossbar: Fix incorrect type of local variables

irqchip/crossbar: Fix incorrect type of local variables
Commit-ID:  b28ace12661fbcfd90959c1e84ff5a85113a82a1
Gitweb:     http://git.kernel.org/tip/b28ace12661fbcfd90959c1e84ff5a85113a82a1
Author:     Franck Demathieu <[email protected]>
AuthorDate: Thu, 23 Feb 2017 10:48:55 +0100
Committer:  Thomas Gleixner <[email protected]>
CommitDate: Wed, 1 Mar 2017 10:08:20 +0100

irqchip/crossbar: Fix incorrect type of local variables

The max and entry variables are unsigned according to the dt-bindings. Fix following 3 sparse issues (-Wtypesign):

drivers/irqchip/irq-crossbar.c:222:52: warning: incorrect type in argument 3 (different signedness)
drivers/irqchip/irq-crossbar.c:222:52: expected unsigned int [usertype] *out_value
drivers/irqchip/irq-crossbar.c:222:52: got int *<noident>

drivers/irqchip/irq-crossbar.c:245:56: warning: incorrect type in argument 4 (different signedness)
drivers/irqchip/irq-crossbar.c:245:56: expected unsigned int [usertype] *out_value
drivers/irqchip/irq-crossbar.c:245:56: got int *<noident>

drivers/irqchip/irq-crossbar.c:263:56: warning: incorrect type in argument 4 (different signedness)
drivers/irqchip/irq-crossbar.c:263:56: expected unsigned int [usertype] *out_value
drivers/irqchip/irq-crossbar.c:263:56: got int *<noident>

---
 drivers/irqchip/irq-crossbar.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/irqchip/irq-crossbar.c +2 -1
index 1eef56a..05bbf17 100644
@@ -198,7 +198,8 @@ static const struct irq_domain_ops crossbar_domain_ops = {
 
 static int __init crossbar_of_init(struct device_node *node)
 {
-	int i, size, max = 0, reserved = 0, entry;
+	int i, size, reserved = 0;
+	u32 max = 0, entry;
 	const __be32 *irqsr;
 	int ret = -ENOMEM;